From: "Rob Herring (Arm)" <robh@kernel.org>
To: Wentao Liang <vulab@iscas.ac.cn>
Cc: saravanak@kernel.org, devicetree@vger.kernel.org,
Julia.Lawall@lip6.fr, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] of/irq: Fix remaining refcount leaks in of_irq_init()
Date: Wed, 30 Sep 2026 16:09:14 -0500 [thread overview]
Message-ID: <179080255383.270996.7058123919952080909.robh@kernel.org> (raw)
In-Reply-To: <20260917124247.2151674-1-vulab@iscas.ac.cn>
On Thu, 17 Sep 2026 12:42:47 +0000, Wentao Liang wrote:
> Successfully initialized controllers are moved to intc_parent_list,
> but the final cleanup only frees the descriptors. The device node
> references taken with of_node_get() and the interrupt parent
> references are therefore leaked on the normal return path. Drop both
> before kfree(), as the intc_desc_list cleanup already does.
>
> Fixes: 8363ccb917c6 ("of/irq: add missing of_node_put")
> Cc: stable@vger.kernel.org
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
> ---
> drivers/of/irq.c | 2 ++
> 1 file changed, 2 insertions(+)
>
Applied, thanks!
prev parent reply other threads:[~2026-09-30 21:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 12:42 Wentao Liang
2026-09-30 21:09 ` Rob Herring (Arm) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179080255383.270996.7058123919952080909.robh@kernel.org \
--to=robh@kernel.org \
--cc=Julia.Lawall@lip6.fr \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=saravanak@kernel.org \
--cc=stable@vger.kernel.org \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®