From: patchwork-bot+netdevbpf@kernel.org
To: Shakeel Butt <shakeel.butt@linux.dev>
Cc: ast@kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com,
andrii@kernel.org, eddyz87@gmail.com, memxor@gmail.com,
martin.lau@linux.dev, song@kernel.org, yonghong.song@linux.dev,
jolsa@kernel.org, emil@etsalapatis.com, ihor.solodrai@linux.dev,
ameryhung@gmail.com, tj@kernel.org, kernel-team@meta.com,
cgroups@vger.kernel.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org, laoar.shao@gmail.com
Subject: Re: [PATCH bpf-next v2] bpf, cgroup: fix cgroup struct_ops query for a second attach type
Date: Thu, 01 Oct 2026 15:50:07 +0000 [thread overview]
Message-ID: <179086980753.2537503.5108865645630186229.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20261001141901.3225830-1-shakeel.butt@linux.dev>
Hello:
This patch was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@kernel.org>:
On Thu, 1 Oct 2026 07:19:01 -0700 you wrote:
> Two things in __cgroup_bpf_query() work only because CGROUP_TCP_SOCK_OPS is
> the only struct_ops attach type.
>
> It calls cgroup_bpf_enabled(atype) with an atype that
> find_atype_by_struct_ops_id() works out at runtime. That macro is an asm
> goto and needs a constant. Today the compiler can see there is only one
> value; add a second type and the build breaks with "impossible constraint
> in 'asm'". The check is not needed anyway. When the key is off nothing is
> attached, so progs[atype] and effective[atype] are empty and the count loop
> leaves total_cnt at 0. The other attach types already use that loop with
> no such check. Drop the check and the skip_count label.
>
> [...]
Here is the summary with links:
- [bpf-next,v2] bpf, cgroup: fix cgroup struct_ops query for a second attach type
https://git.kernel.org/bpf/bpf-next/c/b5a4aa31abd6
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2026-10-01 15:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 14:19 Shakeel Butt
2026-10-01 15:50 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179086980753.2537503.5108865645630186229.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=ameryhung@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=emil@etsalapatis.com \
--cc=ihor.solodrai@linux.dev \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kernel-team@meta.com \
--cc=laoar.shao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=shakeel.butt@linux.dev \
--cc=song@kernel.org \
--cc=tj@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®