From: patchwork-bot+bluetooth@kernel.org
To: Hitalo Souza <enghitalo@gmail.com>
Cc: linux-bluetooth@vger.kernel.org, marcel@holtmann.org,
luiz.dentz@gmail.com, linux-kernel@vger.kernel.org,
michael.bommarito@gmail.com
Subject: Re: [PATCH] Bluetooth: Add missing newline to bt_dev_{err,warn}_ratelimited()
Date: Wed, 07 Oct 2026 17:30:13 +0000 [thread overview]
Message-ID: <179139421378.3628206.2740207447215524505.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20261006212142.2168838-1-enghitalo@gmail.com>
Hello:
This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:
On Tue, 6 Oct 2026 17:21:42 -0400 you wrote:
> bt_dev_err_ratelimited() and bt_dev_warn_ratelimited() pass the format
> string to bt_err_ratelimited()/bt_warn_ratelimited() without appending
> a newline, unlike bt_dev_err() and bt_dev_warn(), which go through
> BT_ERR()/BT_WARN() and add one. Only 2 of the 22 in-tree callers (both
> in virtio_bt) put the newline in their own format string.
>
> A printk record without a trailing newline is stored with prb_commit()
> instead of prb_final_commit(), and readers of the log buffer (/dev/kmsg,
> syslog) do not see it until it is finalized, which only happens when the
> next record is reserved. These messages therefore stay invisible until
> some unrelated message is printed, and journald, which timestamps a
> record when it reads it, logs them with the time of that later message.
>
> [...]
Here is the summary with links:
- Bluetooth: Add missing newline to bt_dev_{err,warn}_ratelimited()
https://git.kernel.org/bluetooth/bluetooth-next/c/f3d041ec63f7
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2026-10-07 17:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-06 21:21 Hitalo Souza
2026-10-07 17:30 ` patchwork-bot+bluetooth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179139421378.3628206.2740207447215524505.git-patchwork-notify@kernel.org \
--to=patchwork-bot+bluetooth@kernel.org \
--cc=enghitalo@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=michael.bommarito@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®