From: "Rob Herring (Arm)" <robh@kernel.org>
To: Rosen Penev <rosenp@gmail.com>
Cc: Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Linus Walleij <linusw@kernel.org>,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
Ray Jui <rjui@broadcom.com>,
devicetree@vger.kernel.org, Scott Branden <sbranden@broadcom.com>
Subject: Re: [PATCH v4] dt-bindings: pinctrl: brcm,nsp-gpio: Convert to DT schema
Date: Wed, 7 Oct 2026 15:41:35 -0500 [thread overview]
Message-ID: <179140569536.225256.15729083704635110285.robh@kernel.org> (raw)
In-Reply-To: <20261004193647.182052-1-rosenp@gmail.com>
On Sun, 04 Oct 2026 12:36:47 -0700, Rosen Penev wrote:
> The brcm,nsp-gpio-a compatible used by the NSP GPIO controller was only
> documented in the legacy text binding, so dtbs_check reported "failed to
> match any schema" for the gpio@20 node in bcm-nsp.dtsi.
>
> Convert the text binding to DT schema. Beyond a direct conversion:
>
> - Require pin configuration nodes to use a '-pins' suffix and GPIO hogs
> a '-hog' suffix, as the old example used arbitrary node names. No
> in-tree DTS has child nodes under this controller, so nothing is
> affected.
> - Document slew-rate, which the driver supports but the text binding
> never listed.
> - Add #interrupt-cells and gpio-line-names, and make #interrupt-cells
> depend on interrupt-controller.
>
> Assisted-by: LLM
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
> v4: rewrite to add extra stuff not present in original.
> v3: add additionalProperties
> v2: don't drop gpio-hog
> .../bindings/pinctrl/brcm,nsp-gpio.txt | 80 -----------
> .../bindings/pinctrl/brcm,nsp-gpio.yaml | 130 ++++++++++++++++++
> 2 files changed, 130 insertions(+), 80 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/pinctrl/brcm,nsp-gpio.txt
> create mode 100644 Documentation/devicetree/bindings/pinctrl/brcm,nsp-gpio.yaml
>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
next prev parent reply other threads:[~2026-10-07 20:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-04 19:36 Rosen Penev
2026-10-07 20:41 ` Rob Herring (Arm) [this message]
2026-10-08 13:09 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179140569536.225256.15729083704635110285.robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=rosenp@gmail.com \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®