From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753318AbdHJXQk (ORCPT <rfc822;w@1wt.eu>);
        Thu, 10 Aug 2017 19:16:40 -0400
Received: from cloudserver094114.home.net.pl ([79.96.170.134]:62244 "EHLO
        cloudserver094114.home.net.pl" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1752440AbdHJXQi (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 10 Aug 2017 19:16:38 -0400
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Punit Agrawal <punit.agrawal@arm.com>
Cc: rafael.j.wysocki@intel.com, linux-acpi@vger.kernel.org,
        Alexey Klimov <alexey.klimov@arm.com>, linux-kernel@vger.kernel.org,
        lorenzo.pieralisi@arm.com, sudeep.holla@arm.com,
        Jassi Brar <jassisinghbrar@gmail.com>
Subject: Re: [PATCH RESEND] mailbox: pcc: Drop uninformative output during boot
Date: Fri, 11 Aug 2017 01:08:18 +0200
Message-ID: <1791419.fgGbrxCany@aspire.rjw.lan>
In-Reply-To: <20170801124357.18344-1-punit.agrawal@arm.com>
References: <20170801124357.18344-1-punit.agrawal@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday, August 1, 2017 2:43:57 PM CEST Punit Agrawal wrote:
> When booting on an ACPI enabled system that does not provide the
> Platform Communications Channel Table (PCCT), the pcc mailbox driver
> prints -
> 
> [    0.484261] PCCT header not found.
> 
> during probe before returning -ENODEV.
> 
> This message clutters the bootlog and doesn't provide any useful
> information. Drop this message.
> 
> Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
> Cc: Jassi Brar <jassisinghbrar@gmail.com>
> Acked-by: Alexey Klimov <alexey.klimov@arm.com>
> ---
> 
> Hi Rafael,
> 
> Re-sending the patch with linux-acpi on cc and tags applied as
> requested. If there are no objections please consider merging.
> 
> Thanks,
> Punit
> 
>  drivers/mailbox/pcc.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c
> index ac91fd0d62c6..3d83cdc11ab5 100644
> --- a/drivers/mailbox/pcc.c
> +++ b/drivers/mailbox/pcc.c
> @@ -457,10 +457,8 @@ static int __init acpi_pcc_probe(void)
>  	/* Search for PCCT */
>  	status = acpi_get_table(ACPI_SIG_PCCT, 0, &pcct_tbl);
>  
> -	if (ACPI_FAILURE(status) || !pcct_tbl) {
> -		pr_warn("PCCT header not found.\n");
> +	if (ACPI_FAILURE(status) || !pcct_tbl)
>  		return -ENODEV;
> -	}
>  
>  	count = acpi_table_parse_entries(ACPI_SIG_PCCT,
>  			sizeof(struct acpi_table_pcct),
> 

Applied, thanks!