Re: [PATCH net-next v14 2/9] dt-bindings: net: dsa: add Microchip LAN9645x switch

["Rob Herring (Arm)" <robh@kernel.org>]

On Thu, 08 Oct 2026 11:05:21 +0200, Jens Emil Schulz Østergaard wrote:
> Add bindings for LAN9645X switch. We use a fallback compatible for the
> smallest SKU microchip,lan96455s-switch. The last digit of the part number
> is the number of usable front ports and the letter is the feature set.
> 
> The switch is a child of an externally controlled parent that hands out
> one regmap per register target, so reg and reg-names describe the target
> layout the way mscc,vsc7514-switch.yaml does for the equivalent
> mscc,vsc7512-switch node. That binding, and the mfd parent it hangs off
> in mscc,ocelot.yaml, is the model this driver and its parent follow.
> 
> Reviewed-by: Steen Hegelund <Steen.Hegelund@microchip.com>
> Signed-off-by: Jens Emil Schulz Østergaard <jensemil.schulzostergaard@microchip.com>
> ---
> Changes in v14:
> - Use the dt-bindings: net: dsa: subject prefix and do not repeat
>   "bindings" in the subject.
> - Describe all switch register targets in reg, and the analyzer and
>   PTP interrupts.
> 
> Changes in v13:
> - Remove section quoting Documentation/networking/phy.rst from commit
>   message.
> - Remove rx/tx-internal-delay-ps from example.
> 
> Changes in v12:
> - Remove Rob's Reviewed-by
> - Match both the port@ and ethernet-port@ spellings, so the per port
>   constraints apply. dsa.yaml accepts either, and the local pattern only
>   matched the long form.
> - Allow 0 as well as 2000 for rx/tx-internal-delay-ps, matching what the
>   driver accepts, and restrict them to those two values on RGMII ports.
> - Constrain the ethernet-ports node the way renesas,rzn1-a5psw.yaml does,
>   with additionalProperties instead of a local dsa-port.yaml $ref.
> - Put the example properties in canonical order, so dt-check-style
>   --mode=strict is clean.
> - Describe the switch register targets in reg, with a matching reg-names,
>   following mscc,vsc7514-switch.yaml.
> - Document the default of rx/tx-internal-delay-ps, as
>   microchip,lan937x.yaml does.
> - Describe the SKU naming in the binding description.
> 
> Changes in v5:
> - No changes.
> 
> Changes in v4:
> - No changes.
> 
> Changes in v3:
> - remove additionalProperties: true
> - remove unnecessary | from description
> - change top level $ref to dsa.yaml#/$defs/ethernet-ports
> - use ethernet-ports and ethernet-port
> - move ethernet-ports under properties instead of patternProperties
> - move unevaluatedProperties: false after $ref
> - update example to use ethernet-ports and ethernet-port
> 
> Changes in v2:
> - rename file to microchip,lan96455s-switch.yaml
> - remove led vendor property
> - add {rx,tx}-internal-delay-ps for rgmii delay
> - remove labels from example
> - remove container node from example
> ---
>  .../net/dsa/microchip,lan96455s-switch.yaml        | 208 +++++++++++++++++++++
>  MAINTAINERS                                        |   1 +
>  2 files changed, 209 insertions(+)
> 

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>