From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99ABB51588E for ; Fri, 9 Oct 2026 18:29:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791570594; cv=none; b=YTWTv1rX6VlP9h3TrW/jcLIBQHmKIGtXYPu6BgRSkHCZFMyU2kYh+2GSeIZzYUqpWB88bGnfwO5UigGHIpkqjxnbMLJzD5J8vjAHUyVLsJUh65CHtk80nJlEHhk2hyXr8A62ccAkl7RYDJNl7/bjQEWFmFIwCe90wjutU4NmbhI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791570594; c=relaxed/simple; bh=XNzr2wNUNghrBBxT8exO2uqCTKmR32NqYT7zK1+uz7E=; h=MIME-Version:Content-Type:Subject:From:To:Cc:In-Reply-To: References:Date:Message-Id; b=CVz80cT9uk+lC/gSMozM1jD7ovIEfvQmq2V5borlf4o+HJMMQnMsUzocE16UkWB5zmkCsd0Xb52SgXcsQhRwmM4WuWme2WGR7zL8CuPUgQp4brvFu7jcjf4Cpgq6jm76B2amOstQSYtIseJTH1jALFGXP9AwQInRAgqeZxhIL1A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=JMH5HjF0; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="JMH5HjF0" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-48c4649b35bso71859f8f.3 for ; Fri, 09 Oct 2026 11:29:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1791570586; x=1792175386; darn=vger.kernel.org; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:content-type:mime-version:from:to:cc :subject:date:message-id:reply-to:content-type; bh=BpjtofrkUDRqvSiMqlyAYlghXPAPat+XcdincmK9q5k=; b=JMH5HjF0gTC8LSamwc1Fsq1sEnBsFhtr8+l6Hb7vRyeuJBHbLEDCbxloyP2cxplCRH JuPVdAwbo6l+Qy7gZ8JDaX+mfzJX9j8RmVwejUmZtnAVouiXzFDr8/R1OlbsfrYwqafu QaYoaQGuAlBtOH28+nXV9hiMr87SNwl/keS+gDL+lS88OpjnrJ704zmd2vcgiQNEIXQw UeS/NiYig/eAHJOYT/VtbnKlo7C2X7qsAxnGmW/Vq9ArXjrIB0cTLSU+Acv1x/PTl98l XrIG6KIc3EExX5keO5zuiDv46ojHhpzbeMkfOet4ENE0E7sN2vUmdtlue+hBfHZZ0HF9 PMNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791570586; x=1792175386; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:content-type:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=BpjtofrkUDRqvSiMqlyAYlghXPAPat+XcdincmK9q5k=; b=gOWdbw8u2n+lkSVktGHgo/wKtzw6Hx7WMmmHtCu18jdwiEEY41Mo8OjjZvm5Dwv3n4 FmMOWJ10tnvsnZqOx+1HQX5cA/nFpUZ7lfaUGM+KBvYHFzMujTzgMPGGTk8qzbAa5tMN +aemYkL1wffyxmpyuiKkk0NoRdiaJOBN1T4LedlF4EgpATbISSb3fQ36hgCMskCm5uPL e3TRgOdtgpFJNECSZTYruKX759JeIw04suSemCVeStCbDiwlEYqjDVCBUwMdRexkA7yd xcpBzzDZITR+JMwsbjnT/sgHdd38hEY0MySUhVWysXD70lhFI/KY/8zA7GXuuVZ81V9R 8hbQ== X-Forwarded-Encrypted: i=1; AKwUvBwuUAyhRcUGYAoUOy7K0pe6f6VGDvHlOGFbW94uL1JK2aNJQuC95owjobLFNv4XwKTcp0cgkOSc1iQEmF8=@vger.kernel.org X-Gm-Message-State: AFuF++kvyJTnKqqKPPyh/BWL8CR8gZ4xhXeTY9is1edv8hlZE5+Lk63o drNFV2u1EaGmCOq7QyMUxLhCVxXGuMc/lTIa6uRSSUHmzihMvjHJm6Ur0YRO45T1gMs= X-Gm-Gg: AYBFou23gEz83689V26CVVKa9pVn4C+GJcGBaDDXjhmXEVAzIsUCgeip6512g0QFVH9 KXMQ0XsL5n48eoZjvy7ITtxecAP9HPTWSIdxpvLLn1AenSpQsF3EVi8zlPkLsLCECQcwfv8iDdf xEdmVETg7dMxg+AccUQoruQ9ScD4sTNFI/OIlwyixXRiRbqSJXy3k1V2/qnaR9nf+zYCEsOvaC0 BQrSYOMfdJMLgFRvrLbo9iXxcAcTCeMxMD3/DUAFVwrHqKG06Be50mSFTNvUpJDeI0791oktHzv ZKdy8i8OQ6ZAMl1dLIaE6m8rcoY/NodQqEikmY4HSyLBrq1eSWMBXrKXV9cERzZUS3xkp53L8W5 Ig4xF0s7Fyj2mIaO0mQiN4TkJU4ZuJrwVCyHLm+4/tF4kCcChBOlYj+IEdF9PkvpwP+rfV39fDj RE6sHyzFionhWkiF1ie1OgUBZTtz2abB6+4GfE3nUJCSjBKRl9niSSJOentwVLSPqh8AieW1I+d peudJZDJXz6Zrmkfg== X-Received: by 2002:a05:600c:c165:b0:4a1:706f:b40d with SMTP id 5b1f17b1804b1-4a18e4988ecmr56332465e9.7.1791570585690; Fri, 09 Oct 2026 11:29:45 -0700 (PDT) Received: from localhost (82-67-6-57.subs.proxad.net. [82.67.6.57]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a18e48db03sm95749805e9.3.2026.10.09.11.29.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Oct 2026 11:29:45 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v15 06/11] clk: realtek: Add support for gate clock From: Jerome Brunet To: Yu-Chun Lin Cc: jbrunet+clk@baylibre.com, sboyd@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, p.zabel@pengutronix.de, cylee12@realtek.com, afaerber@suse.com, jyanchou@realtek.com, bmasney+clk@redhat.com, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-realtek-soc@lists.infradead.org, james.tai@realtek.com, cy.huang@realtek.com, stanley_chang@realtek.com, Brian Masney In-Reply-To: <20261002074331.3066919-7-eleanor.lin@realtek.com> References: <20261002074331.3066919-1-eleanor.lin@realtek.com> <20261002074331.3066919-7-eleanor.lin@realtek.com> Date: Fri, 09 Oct 2026 20:29:35 +0200 Message-Id: <179157057524.266328.4248123787670079601.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=5945; i=jbrunet@baylibre.com; h=from:subject:message-id; bh=XNzr2wNUNghrBBxT8exO2uqCTKmR32NqYT7zK1+uz7E=; b=owGbwMvMwCW2VtK+WnvWU3HG02pJDFknjaae9uxc/m6+QK2RgueRBvebz8Lz10RPbDsVbijMb bFoSRBrRykLgxgXg6yYIksNd7X4O0mtL7Om69yGmcPKBDKEgYtTACYSksHwhzvIVES3Pend/cIn NZOPsmdNNlKbJujvIiDq0L1+IldIOMP/hGq/KXtqPh1ezP+T2/2CvdnnaxvU/RcwxFx6o1Tb7Gf IAgA= X-Developer-Key: i=jbrunet@baylibre.com; a=openpgp; fpr=F29F26CF27BAE1A9719AE6BDC3C92AAF3E60AED9 > Introduce clk_regmap_gate_ops supporting enable, disable, and is_enabled > for standard regmap gate clocks. To accommodate hardware designs, the > enable and disable operations handle a 'write_en' flag, which asserts an > adjacent write-enable bit (bit_idx + 1) simultaneously when modifying the > gate bit. > > Add clk_regmap_gate_ro_ops as a read-only variant exposing only is_enabled. > > Signed-off-by: Cheng-Yu Lee > Co-developed-by: Yu-Chun Lin > Signed-off-by: Yu-Chun Lin > Reviewed-by: Brian Masney > > diff --git a/drivers/clk/realtek/Makefile b/drivers/clk/realtek/Makefile > index 71edc18121c6..840aff067b61 100644 > --- a/drivers/clk/realtek/Makefile > +++ b/drivers/clk/realtek/Makefile > @@ -3,4 +3,5 @@ obj-$(CONFIG_RTK_CLK_COMMON) += clk-rtk.o > > clk-rtk-y += clk-rtk-common.o > clk-rtk-y += clk-pll.o > +clk-rtk-y += clk-regmap-gate.o > clk-rtk-y += freq_table.o > diff --git a/drivers/clk/realtek/clk-regmap-gate.c b/drivers/clk/realtek/clk-regmap-gate.c > new file mode 100644 > index 000000000000..7033aeb1cd82 > --- /dev/null > +++ b/drivers/clk/realtek/clk-regmap-gate.c > @@ -0,0 +1,64 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (C) 2017-2026 Realtek Semiconductor Corporation > + * Author: Cheng-Yu Lee > + */ > + > +#include > +#include > +#include > +#include > +#include "clk-regmap-gate.h" > + > +static int rtk_clk_regmap_gate_update(struct clk_hw *hw, bool enable) > +{ > + struct rtk_clk_regmap_gate *clkg = to_rtk_clk_regmap_gate(hw); > + unsigned int mask = BIT(clkg->bit_idx); > + unsigned int val = enable ? mask : 0; > + > + /* > + * Hardware specific design: to modify the gate bit, the adjacent > + * write-enable bit (bit_idx + 1) must be asserted simultaneously. > + */ > + if (clkg->write_en) { > + mask |= BIT(clkg->bit_idx + 1); > + val |= BIT(clkg->bit_idx + 1); > + } > + > + return regmap_update_bits(clkg->clkr.regmap, clkg->gate_ofs, mask, val); > +} > + > +static int rtk_clk_regmap_gate_enable(struct clk_hw *hw) > +{ > + return rtk_clk_regmap_gate_update(hw, true); > +} > + > +static void rtk_clk_regmap_gate_disable(struct clk_hw *hw) > +{ > + rtk_clk_regmap_gate_update(hw, false); > +} > + > +static int rtk_clk_regmap_gate_is_enabled(struct clk_hw *hw) > +{ > + struct rtk_clk_regmap_gate *clkg = to_rtk_clk_regmap_gate(hw); > + int ret; > + u32 val; > + > + ret = regmap_read(clkg->clkr.regmap, clkg->gate_ofs, &val); > + if (ret < 0) > + return ret; > + > + return !!(val & BIT(clkg->bit_idx)); > +} > + > +const struct clk_ops rtk_clk_regmap_gate_ops = { > + .enable = rtk_clk_regmap_gate_enable, > + .disable = rtk_clk_regmap_gate_disable, > + .is_enabled = rtk_clk_regmap_gate_is_enabled, > +}; > +EXPORT_SYMBOL_NS_GPL(rtk_clk_regmap_gate_ops, "CLK_REALTEK"); > + > +const struct clk_ops rtk_clk_regmap_gate_ro_ops = { > + .is_enabled = rtk_clk_regmap_gate_is_enabled, > +}; > +EXPORT_SYMBOL_NS_GPL(rtk_clk_regmap_gate_ro_ops, "CLK_REALTEK"); > diff --git a/drivers/clk/realtek/clk-regmap-gate.h b/drivers/clk/realtek/clk-regmap-gate.h > new file mode 100644 > index 000000000000..9303adda3166 > --- /dev/null > +++ b/drivers/clk/realtek/clk-regmap-gate.h > @@ -0,0 +1,65 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * Copyright (C) 2017-2026 Realtek Semiconductor Corporation > + * Author: Cheng-Yu Lee > + */ > + > +#ifndef __CLK_REALTEK_CLK_REGMAP_GATE_H > +#define __CLK_REALTEK_CLK_REGMAP_GATE_H > + > +#include "clk-rtk-common.h" > + > +struct rtk_clk_regmap_gate { > + struct rtk_clk_regmap clkr; > + unsigned int gate_ofs; > + u8 bit_idx; > + u32 write_en : 1; > +}; > + > +#define __rtk_clk_regmap_gate_hw(_p) __rtk_clk_regmap_hw(&(_p)->clkr) > + > +#define __RTK_CLK_REGMAP_GATE(_name, _parent, _ops, _flags, _ofs, _bit_idx, \ > + _write_en) \ > + struct rtk_clk_regmap_gate _name = { \ > + .clkr.hw.init = CLK_HW_INIT(#_name, _parent, _ops, _flags), \ > + .gate_ofs = _ofs, \ > + .bit_idx = _bit_idx, \ > + .write_en = _write_en, \ > + } > + > +#define RTK_CLK_REGMAP_GATE(_name, _parent, _flags, _ofs, _bit_idx, _write_en) \ > + __RTK_CLK_REGMAP_GATE(_name, _parent, &rtk_clk_regmap_gate_ops, _flags, _ofs, \ > + _bit_idx, _write_en) > + > +#define RTK_CLK_REGMAP_GATE_RO(_name, _parent, _flags, _ofs, _bit_idx, _write_en) \ > + __RTK_CLK_REGMAP_GATE(_name, _parent, &rtk_clk_regmap_gate_ro_ops, _flags, \ > + _ofs, _bit_idx, _write_en) > + > +#define __RTK_CLK_REGMAP_GATE_NO_PARENT(_name, _ops, _flags, _ofs, _bit_idx, \ > + _write_en) \ > + struct rtk_clk_regmap_gate _name = { \ > + .clkr.hw.init = CLK_HW_INIT_NO_PARENT(#_name, _ops, _flags), \ > + .gate_ofs = _ofs, \ > + .bit_idx = _bit_idx, \ > + .write_en = _write_en, \ > + } > + > +#define RTK_CLK_REGMAP_GATE_NO_PARENT(_name, _flags, _ofs, _bit_idx, _write_en) \ > + __RTK_CLK_REGMAP_GATE_NO_PARENT(_name, &rtk_clk_regmap_gate_ops, _flags, _ofs, \ > + _bit_idx, _write_en) > + > +#define RTK_CLK_REGMAP_GATE_NO_PARENT_RO(_name, _flags, _ofs, _bit_idx, _write_en) \ > + __RTK_CLK_REGMAP_GATE_NO_PARENT(_name, &rtk_clk_regmap_gate_ro_ops, _flags, \ > + _ofs, _bit_idx, _write_en) Is this _NO_PARENT still used ? if not drop it -- Jerome