From: "tip-bot2 for Eliav Farber" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Eliav Farber <farbere@amazon.com>,
Thomas Gleixner <tglx@kernel.org>, Radu Rendec <radu@rendec.net>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: irq/drivers] irqchip/al-fic: Use %pOF and raise init log level
Date: Thu, 15 Oct 2026 12:32:28 -0000 [thread overview]
Message-ID: <179206754872.2666988.1590682003502575644.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20261011050449.41903-4-farbere@amazon.com>
The following commit has been merged into the irq/drivers branch of tip:
Commit-ID: da0b1e5f7a124c5c506baef32ed7a90aa03cf516
Gitweb: https://git.kernel.org/tip/da0b1e5f7a124c5c506baef32ed7a90aa03cf516
Author: Eliav Farber <farbere@amazon.com>
AuthorDate: Sun, 11 Oct 2026 05:04:42
Committer: Thomas Gleixner <tglx@kernel.org>
CommitterDate: Thu, 15 Oct 2026 14:25:06 +02:00
irqchip/al-fic: Use %pOF and raise init log level
Use %pOF in the driver's log messages, so that both the success and the
error paths identify the specific FIC instance by its full devicetree
path rather than by its bare node name, e.g.:
/soc/interrupt-controller@fd803000 initialized successfully in Legacy mode (parent-irq=3)
A single controller is described by several FIC nodes that share the same
bare node name (e.g. "interrupt-controller"), so the bare name cannot tell
one instance from another. The full path includes the unit address and
keeps the instances distinguishable.
While converting the parent-missing message, fix a grammar typo in it
("device require a parent" -> "device requires a parent").
Raise the successful-initialization message from pr_debug to pr_info, as
this single boot-time printout is useful when dynamic debug is not enabled
at this stage of boot.
Signed-off-by: Eliav Farber <farbere@amazon.com>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Reviewed-by: Radu Rendec <radu@rendec.net>
Link: https://patch.msgid.link/20261011050449.41903-4-farbere@amazon.com
---
drivers/irqchip/irq-al-fic.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/irqchip/irq-al-fic.c b/drivers/irqchip/irq-al-fic.c
index a513d0d..ac979c3 100644
--- a/drivers/irqchip/irq-al-fic.c
+++ b/drivers/irqchip/irq-al-fic.c
@@ -205,8 +205,8 @@ static struct al_fic *al_fic_wire_init(struct device_node *node, void __iomem *b
goto err_free;
}
- pr_debug("%s initialized successfully in Legacy mode (parent-irq=%u)\n",
- fic->name, parent_irq);
+ pr_info("%pOF initialized successfully in Legacy mode (parent-irq=%u)\n",
+ node, parent_irq);
return fic;
@@ -223,19 +223,19 @@ static int __init al_fic_init_dt(struct device_node *node, struct device_node *p
int ret;
if (!parent) {
- pr_err("%s: unsupported - device require a parent\n", node->name);
+ pr_err("%pOF: unsupported - device requires a parent\n", node);
return -EINVAL;
}
base = of_iomap(node, 0);
if (!base) {
- pr_err("%s: fail to map memory\n", node->name);
+ pr_err("%pOF: fail to map memory\n", node);
return -ENOMEM;
}
parent_irq = irq_of_parse_and_map(node, 0);
if (!parent_irq) {
- pr_err("%s: fail to map irq\n", node->name);
+ pr_err("%pOF: fail to map irq\n", node);
ret = -EINVAL;
goto err_unmap;
}
@@ -243,7 +243,7 @@ static int __init al_fic_init_dt(struct device_node *node, struct device_node *p
fic = al_fic_wire_init(node, base, node->name, parent_irq);
if (IS_ERR(fic)) {
- pr_err("%s: fail to initialize irqchip (%pe)\n", node->name, fic);
+ pr_err("%pOF: fail to initialize irqchip (%pe)\n", node, fic);
ret = PTR_ERR(fic);
goto err_irq_dispose;
}
next prev parent reply other threads:[~2026-10-15 12:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-11 5:04 [PATCH v5 0/9] irqchip/al-fic: shared parent IRQ, error/fatal outputs and affinity Eliav Farber
2026-10-11 5:04 ` [PATCH v5 1/9] irqchip/al-fic: fix argument alignment and a repeated word Eliav Farber
2026-10-15 12:32 ` [tip: irq/drivers] irqchip/al-fic: Fix coding style issues tip-bot2 for Eliav Farber
2026-10-11 5:04 ` [PATCH v5 2/9] irqchip/al-fic: use %pe to print init error Eliav Farber
2026-10-12 18:42 ` Radu Rendec
2026-10-15 12:32 ` [tip: irq/drivers] irqchip/al-fic: Use " tip-bot2 for Eliav Farber
2026-10-11 5:04 ` [PATCH v5 3/9] irqchip/al-fic: use %pOF and raise init log level Eliav Farber
2026-10-15 12:32 ` tip-bot2 for Eliav Farber [this message]
2026-10-11 5:04 ` [PATCH v5 4/9] irqchip/al-fic: keep the device_node instead of a cached name string Eliav Farber
2026-10-12 18:53 ` Radu Rendec
2026-10-15 12:32 ` [tip: irq/drivers] irqchip/al-fic: Keep " tip-bot2 for Eliav Farber
2026-10-11 5:04 ` [PATCH v5 5/9] irqchip/al-fic: switch to shared parent interrupt Eliav Farber
2026-10-15 12:32 ` [tip: irq/drivers] irqchip/al-fic: Switch " tip-bot2 for Eliav Farber
2026-10-11 5:04 ` [PATCH v5 6/9] dt-bindings: interrupt-controller: amazon,al-fic: add mask selection Eliav Farber
2026-10-15 12:32 ` [tip: irq/drivers] dt-bindings: interrupt-controller: amazon,al-fic: Add " tip-bot2 for Eliav Farber
2026-10-11 5:04 ` [PATCH v5 7/9] irqchip/al-fic: support error and fatal outputs and FIC v2 Eliav Farber
2026-10-15 12:32 ` [tip: irq/drivers] irqchip/al-fic: Support " tip-bot2 for Eliav Farber
2026-10-11 5:04 ` [PATCH v5 8/9] irqchip/al-fic: add support for FIC v3 Eliav Farber
2026-10-15 12:32 ` [tip: irq/drivers] irqchip/al-fic: Add " tip-bot2 for Eliav Farber
2026-10-11 5:04 ` [PATCH v5 9/9] irqchip/al-fic: support per-child affinity via interrupt redirection Eliav Farber
2026-10-12 19:10 ` Radu Rendec
2026-10-15 12:32 ` [tip: irq/drivers] irqchip/al-fic: Support " tip-bot2 for Eliav Farber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179206754872.2666988.1590682003502575644.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=farbere@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=radu@rendec.net \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®