mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Jeremy Dean Clifton <deaner92@yahoo.com>
Cc: devicetree@vger.kernel.org, linux-pwm@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Uwe Kleine-König" <ukleinek@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>
Subject: Re: [PATCH v3] dt-bindings: pwm: Convert NXP PCA9685 PWM controller to DT schema
Date: Thu, 15 Oct 2026 15:23:23 -0500	[thread overview]
Message-ID: <179209579979.3002119.6334359092410993613.robh@kernel.org> (raw)
In-Reply-To: <20261012140346.3065-1-deaner92@yahoo.com>


On Mon, 12 Oct 2026 14:03:46 +0000, Jeremy Dean Clifton wrote:
> Convert the NXP PCA9685 PWM controller binding to DT schema format.
> 
> Changes from the text binding:
> 
> Document the 'reg' property and make it required. It was missing
> from the text binding, although the example used it and the device
> cannot work without the I2C address.
> 
> Rename the example node to the generic 'pwm', as required by
> pwm.yaml.
> 
> Describe both cells of the PWM specifier, and state that 'invert'
> and 'open-drain' apply to all outputs, as per the datasheet (INVRT
> and OUTDRV bits in MODE2).
> 
> Assisted-by: LLM
> Signed-off-by: Jeremy Dean Clifton <deaner92@yahoo.com>
> ---
> Changes in v3:
> - Full name in From, Signed-off-by and maintainers. (Jeremy Dean
>   Clifton)
> v2:
> https://lore.kernel.org/all/0aabb9f2-a144-4267-b67e-a0972d228f2a@yahoo.com/
> though the storage width was widened.
> - Use the same name in 'maintainers' as in the Signed-off-by.
> 
> v1:
> https://lore.kernel.org/all/20261006033518.34332-1-deaner92@yahoo.com/
> 
> The schema and commit message were drafted with AI assistant.
> I verified each property against the driver source, the
> PCA9685 datasheet and the binding. Passes make dt_binding_check.
> 
>  .../bindings/pwm/nxp,pca9685-pwm.txt          | 27 --------
>  .../bindings/pwm/nxp,pca9685-pwm.yaml         | 62 +++++++++++++++++++
>  2 files changed, 62 insertions(+), 27 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/pwm/nxp,pca9685-pwm.txt
>  create mode 100644 Documentation/devicetree/bindings/pwm/nxp,pca9685-pwm.yaml
> 

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>


  reply	other threads:[~2026-10-15 20:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20261012140346.3065-1-deaner92.ref@yahoo.com>
2026-10-12 14:03 ` Jeremy Dean Clifton
2026-10-15 20:23   ` Rob Herring (Arm) [this message]
2026-10-16 10:33   ` Uwe Kleine-König
2026-10-20 15:13     ` Jeremy Clifton
2026-10-21  5:56       ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179209579979.3002119.6334359092410993613.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=deaner92@yahoo.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=ukleinek@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®