mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: fujo <hooyan2024@gmail.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: linux-fsdevel@vger.kernel.org,
	Christian Brauner <brauner@kernel.org>,
	Alexander Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] selftests/pidfd: wait for POLLHUP before reading exit info
Date: Sun, 18 Oct 2026 12:48:50 -0400	[thread overview]
Message-ID: <179234213014.649.13402722495876323247@gmail.com> (raw)
In-Reply-To: <atTy6LziL5fdGTkn@redhat.com>

Hi Oleg,

> This chunk doesn't look right, POLLIN makes more sense in this case.
> Unless I am confused, this poll(timeout = 0) tries to verify that the
> child does not exit and report POLLIN, with or without POLLHUP.

You are right, thanks.  That poll() is a liveness check, not an
exit-info wait, so v3 keeps POLLIN there and only switches the polls
that are followed by PIDFD_GET_INFO.

About the documentation: there is no in-tree KAPI file for this; the
wording I referred to is the CLONE_AUTOREAP series description ("poll
the child's exit via poll() and retrieve exit status via
PIDFD_GET_INFO").  If you or Christian think a clarifying sentence
belongs somewhere in the tree, I'm happy to send it, but I didn't want
to guess where.

Thanks,
fujo

  parent reply	other threads:[~2026-10-18 16:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-17  5:43 [RFC PATCH] pidfs: don't report autoreaped tasks readable before exit info exists fujo
2026-10-17 13:48 ` Oleg Nesterov
2026-10-17 19:23 ` [PATCH v2] selftests/pidfd: wait for POLLHUP before reading exit info fujo
2026-10-18 16:25   ` Oleg Nesterov
2026-10-18 16:48     ` [PATCH v3] " fujo
2026-10-18 16:48     ` fujo [this message]
2026-10-18 19:27       ` [PATCH v2] " Oleg Nesterov
2026-10-17 19:23 ` [RFC PATCH] pidfs: don't report autoreaped tasks readable before exit info exists fujo
2026-10-18 16:30   ` Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179234213014.649.13402722495876323247@gmail.com \
    --to=hooyan2024@gmail.com \
    --cc=brauner@kernel.org \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®