From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CC84499F31 for ; Mon, 19 Oct 2026 12:01:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792411291; cv=none; b=JF2lmXAsJzXsEtYyXvx6DjwlOTrD6bHRlE/AeFW2Mpvx84W9949ueQSIKbV7tQHvMs3/x+aJShSjMqzRM3Uv8ZAQpUOY6kqbifUw2S63fENQcD3Z6EcCbgqJ/chEO/rfEz6uO7kzqNzEvYNpROfAJDrLm5++xI2KBAkH/d1JPlc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792411291; c=relaxed/simple; bh=a+JFhcktEUT/otUAjLtO1S11cPdVYmE+Lbqz7XLfBh4=; h=MIME-Version:Content-Type:Subject:From:To:Cc:In-Reply-To: References:Date:Message-Id; b=dWVagIca5q/iT8nMxKXmZ/xXWwb2ZHvVf4g5hQTgChD5T4sbN8Oi4m5sPU8WFlBf5kKuimXaleRoHxshkWX5S5JREa8OAN5sne9SuVB7B9ECROzGptuhZ5Ucg/kN3Q++iPi7PYTRZodgwwe6u9d5lGbaboZeygwhAcj5GvHBWhE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=E2juYitc; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=B+5CrO4G; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=lyYoJ6Ji; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=X/4CYOJS; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="E2juYitc"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="B+5CrO4G"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="lyYoJ6Ji"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="X/4CYOJS" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A551D21CAB; Mon, 19 Oct 2026 12:01:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1792411283; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eizw4Kp0fIdeSJH2kfJJvLAORXAdc5N5Ckf4TmLSqPo=; b=E2juYitcp/qobVMtOz9jE853ph6Gq1X9Zo7mt01mrGjaRRJ1xLxgTl1BhBqot+Bb0EXJhF wHn8lacXnqkwMZoQFugyAwQkd/w46D7jjX1gf0tsP+y/ibEsyWI9GPYqVX90gVTdWxOHuR YQvX2BIqeZ9DWvSpPdMWEtrQn3jMGq0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1792411283; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eizw4Kp0fIdeSJH2kfJJvLAORXAdc5N5Ckf4TmLSqPo=; b=B+5CrO4GXcb2bzjj+cekLWGvGil3GioODo37qAn17GSktk2LJyn5tjeFP1VHYPct/LRGpS NIxhKw8Tg8jQINBg== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=lyYoJ6Ji; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="X/4CYOJS" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1792411278; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eizw4Kp0fIdeSJH2kfJJvLAORXAdc5N5Ckf4TmLSqPo=; b=lyYoJ6JiarDMyrCxZqTcc2OA2F/+J9aCig+Xsp/07GwWWGsxWURhEPzv5R2Y+UKk1TnX8A H92jL14TrFLys/5abUjf1LVLI7IHaVFqxen7naykFdnvem93qzYgCg/b/7t+pCEvEaMtw6 i8JodyS5aFqLyP87p6dLUAx598h3kMM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1792411278; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eizw4Kp0fIdeSJH2kfJJvLAORXAdc5N5Ckf4TmLSqPo=; b=X/4CYOJShcC0aCzxwrpzZpEi37m9AOys9POzAd2xR6sIx6Muy37Rl0pc7PYp+avCrU8OKW 0B2hexYJjVF4eXAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6B996136CC; Mon, 19 Oct 2026 12:01:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Vi1wFI4G1mojTAAAD6G6ig (envelope-from ); Mon, 19 Oct 2026 12:01:18 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v6 02/18] nvmet/debugfs: Export controller CIU and CIRN via debugfs From: Daniel Wagner To: Mohamed Khalfella Cc: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Justin Tee , Naresh Gottumukkala , Paul Ely , Hannes Reinecke , Chaitanya Kulkarni , James Smart , Randy Jennings , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Hannes Reinecke In-Reply-To: <20260920182936.2317916-3-mkhalfella@purestorage.com> References: <20260920182936.2317916-1-mkhalfella@purestorage.com> <20260920182936.2317916-3-mkhalfella@purestorage.com> Date: Mon, 19 Oct 2026 14:01:13 +0200 Message-Id: <179241127352.3544975.2554197788837860779.b4-reply@b4> X-Mailer: b4 0.16.0 X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: A551D21CAB X-Rspamd-Action: no action X-Spam-Level: X-Spamd-Result: default: False [-4.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_RHS_NOT_FQDN(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_TWELVE(0.00)[15]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from,2a07:de40:b281:106:10:150:64:167:received]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[kernel.org,kernel.dk,lst.de,grimberg.me,broadcom.com,gmail.com,nvidia.com,purestorage.com,lists.infradead.org,vger.kernel.org,suse.de]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:email,suse.de:dkim]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Spam-Flag: NO X-Spam-Score: -4.01 On 2026-09-20 11:28 -0700, Mohamed Khalfella wrote: > Export ctrl->ciu and ctrl->cirn as debugfs files under controller > debugfs directory. Could you add the 'why' part to the commit message? > > Signed-off-by: Mohamed Khalfella > Reviewed-by: Hannes Reinecke > Reviewed-by: Sagi Grimberg Besides the missing 'why', it looks good. Reviewed-by: Daniel Wagner