Re: [PATCH net-next 2/3] net: qrtr: propagate sock_alloc_send_skb() errors from sendmsg()

[netdev-bot+sashiko@kernel.org]

Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.

Low priority / nit picks for your consideration:

- [Low] The patch fixes a userspace-visible errno regression in
  qrtr_sendmsg() (net/qrtr/af_qrtr.c) and names the commit that caused…

--

net: qrtr: propagate sock_alloc_send_skb() errors from sendmsg()

This patch removes the rc = -ENOMEM override in qrtr_sendmsg() that runs
when sock_alloc_send_skb() fails. The error set by the helper is now
returned to userspace instead. This brings back reporting of a pending
ENETRESET from qrtr_reset_ports(), as well as -EAGAIN, -EPIPE and signal
errors.

> Since commit 179d0ba0c454 ("net: qrtr: fix error return code of
> qrtr_sendmsg()"), qrtr_sendmsg() returns -ENOMEM whenever
> sock_alloc_send_skb() fails. The helper already sets rc on every failure
> path, so this overwrites the real error.

[ ... ]

> Signed-off-by: Chunkai Deng <chunkai.deng@oss.qualcomm.com>

[Severity: Low]
This isn't a bug, but the body names the commit that introduced the
-ENOMEM override. Should the patch also carry a Fixes: trailer for it?

Fixes: 179d0ba0c454 ("net: qrtr: fix error return code of qrtr_sendmsg()")

179d0ba0c454 has been in stable kernels since v5.12. Without the tag, the
stable backport tooling may not pick up this fix. Those kernels would then
keep returning -ENOMEM in these cases:

A pending ENETRESET set by qrtr_reset_ports(). sock_error() clears it when
it reads it inside sock_alloc_send_pskb(), so the notification is lost.

MSG_DONTWAIT senders with a full sndbuf, which should get -EAGAIN.

SEND_SHUTDOWN (-EPIPE) and signal interruptions (-ERESTARTSYS/-EINTR).

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261016-qrtr-add-shutdown-v1-0-e1cc01ca5919%40oss.qualcomm.com