Re: [PATCH net-next v2 2/3] dt-bindings: net: qcom,ipq9574-ppe: Add IPQ5332 support

[netdev-bot+sashiko@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue(s) to consider.

Critical: 0 · High: 0 · Medium: 1 · Low: 0

If you believe none of the issues are legitimate, please reply to each
issue of Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply
(one such reply per series is enough).

- [Medium] The IPQ5332 port conditional in
  Documentation/devicetree/bindings/net/qcom,ipq9574-ppe.yaml (allOf[1]…

--

dt-bindings: net: qcom,ipq9574-ppe: Add IPQ5332 support

This adds the qcom,ipq5332-ppe compatible to the IPQ9574 PPE binding. It
also adds per-SoC conditional blocks that constrain clocks, interconnects,
EDMA resets, interrupts and ring names. IPQ5332 port nodes are meant to be
limited to port IDs 1 and 2.

> diff --git a/Documentation/devicetree/bindings/net/qcom,ipq9574-ppe.yaml b/Documentation/devicetree/bindings/net/qcom,ipq9574-ppe.yaml
> index 6d0b21a10732a..1e95f3a1d0b12 100644
> --- a/Documentation/devicetree/bindings/net/qcom,ipq9574-ppe.yaml
> +++ b/Documentation/devicetree/bindings/net/qcom,ipq9574-ppe.yaml

[ ... ]

> @@ -229,6 +246,65 @@ required:
>  
>  allOf:
>    - $ref: ethernet-switch.yaml
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: qcom,ipq5332-ppe
> +    then:

[ ... ]

> +      patternProperties:
> +        "^(ethernet-)?ports$":
> +          patternProperties:
> +            "^(ethernet-)?port@[0-9a-f]+$":
> +              properties:
> +                reg:
> +                  maximum: 2

[Severity: Medium]
The commit message says:

  IPQ5332 takes four interconnects and only port IDs 1 and 2 ...
  Apply the port-count limit to both container and port naming forms.

Does this block reject port ID 0? It only sets maximum: 2. The only lower
bound in the file is in the base ethernet-ports schema:

  ethernet-ports:
    patternProperties:
      "^ethernet-port@[1-6]+$":
        ...
        properties:
          reg:
            minimum: 1
            maximum: 6

That pattern does not match ethernet-port@0. It also does not apply to a
container named ports. Nodes like these are matched only by the generic
'^(ethernet-)?port@[0-9a-f]+$' pattern in ethernet-switch.yaml, which is
just type: object.

With compatible = "qcom,ipq5332-ppe", would both of these pass
dt_binding_check?

  ethernet-ports {
      ethernet-port@0 {
          reg = <0>;
      };
  };

  ports {
      port@0 {
          reg = <0>;
      };
  };

If so, the accepted set is {0, 1, 2}, not {1, 2}. Port 0 is the CPU port
according to the updated description.

These nodes also skip the per-MAC clocks, clock-names, resets and
reset-names. Those are only required under "^ethernet-port@[1-6]+$". The
ports/port@ spelling already skipped them on IPQ9574, but this block now
applies per-SoC port constraints to that form as well.

Would adding minimum: 1 next to maximum: 2 here fix this? A shared lower
bound in the base schema that covers both naming forms would also work.

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261016152449.934312-1-mail%40tk154.de