From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.219.43 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792532922; b=RV2e7un1VkiFWF+v15bTpy/8w4mLWYHBD5rYCy36Kv+BPjXMrnTpMpMlM40xY7s/QWbF qULIwN8PlXsNyJw+BVqsRRgNayUWi+WtP20uXg/qQzK9FCODn5LFa/QVTm2YL0HOzOj06 +n5c7VES//6BLf+8k4imu51/+ofoVm0OV0xzrDoBa4vi7d5iBSKzLMPdrmxQFHKJEeQLG rVOzP1QQ5vFnrt5D902Ad+h1LlvDKDRFa+j85WJepVT0R11hzqm5HZomV7cVjWsqZaVpk yLvJzePe0KAPW/s2A5S1AWWQOOrAq9I9QJXBl1yBg37OZQ6BP23TGJlVTFo923vFdrg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792532922; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: MIME-Version:Content-Type:Content-Transfer-Encoding:Subject:From:To: Cc:In-Reply-To:References:Date:Message-Id:X-Mailer; bh=lwH5lbGW7Jp7v2pgahH/8u5d5Q1US/ZAJYtMLpAtA4s=; b=lfSLezTkr4ERGgQjBFfrCMw+X4EUoHt5PlLCbwaRZ7uokiQ6kbzvT69ePNVQujqFke22 J4t/DeYKSg+XeWtwpsnM2lf4g1lybmps0DUVYfOCkj01fiTu3vGwTJlDMR6FzEK2RUr8H qWbW8HtmfRXIx5RIiMa7JKz2+Y2YOnOA7YxGwncgieDUhr0/ALgdT3Zs+wY1rc03/o23p 7l4I6AltHaCuUykzNlIF6QiUdgEIV1gbvfTQipcT8PA/nRawz4qm1AwMFvwUTluLMRY91 n/5I7EUg9IJPs8zjeM3iHK48970v2Bji1JcFIWmQrPs1K2OgLM85dGVL0A8shDdFygQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass header.d=gourry.net header.i=@gourry.net header.a=rsa-sha256 header.s=google header.b=Vnm419Qa; arc=none smtp.remote-ip=209.85.219.43 Received: from mail-qv1-f43.google.com (mail-qv1-f43.google.com [209.85.219.43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D096606A31C for ; Tue, 20 Oct 2026 21:48:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 9D096606A31C Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gourry.net header.i=@gourry.net header.a=rsa-sha256 header.s=google header.b=Vnm419Qa Received: by mail-qv1-f43.google.com with SMTP id 6a1803df08f44-91b89c6caffso1149176d6.2 for ; Tue, 20 Oct 2026 14:48:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1792532920; x=1793137720; darn=vger.kernel.org; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:content-type:mime-version:from:to:cc :subject:date:message-id:reply-to:content-type; bh=lwH5lbGW7Jp7v2pgahH/8u5d5Q1US/ZAJYtMLpAtA4s=; b=Vnm419Qa/kjE27NqFknpFQG1AEpyq49ddgDDuGG4m4PuK8jB4BIucxesyWwSf4SEa0 uSz2H8eWQ3QAQVj6mvZloHz1ezWLtzmCORiSuo4nvX/Y89/2PHrTr2TW0P6Tm5o1c13y kFggrh0Im+PIpGTSB7fqkFQNt8NQtpgWN8Og3tQl5MkWnwnj8MF/yt/hQt64q5Q4ESGC hfbLwpJB1hqraCnMet5mFnXiToBilJJr7Z42YzL3pjg2EM6cMOlxUZWGIUnaMwpSxLeW e0X1EurcmLyvexnjMFYKgO/omwKsQow1isD1OoopS7BI9x0SWOD2yG9zXJviPhqLpw95 dF7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792532920; x=1793137720; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:content-type:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=lwH5lbGW7Jp7v2pgahH/8u5d5Q1US/ZAJYtMLpAtA4s=; b=puYHWuhDXur2lr8TU9H2QyMZQQMmgGf9XQo8+Y3YoaQD0QotOvjfyI6zrHne9VTJ9s q5ESNWHVJZyK/DVLYOB1omZT4+0A6IA86BTtB6ok6yZlKGi8qHn29TxO2S5mK2Nc5DbC 3Di5hIX6T/B4YLPoryGQhWJmiTpTll+bSsufE2q9qvt0h2V6qh4lsc+FuB1DALJi5ouU ag4UNcHSaQ+s6mw0w0qCasbN6t6TZgD+A//vRsWv2Ruk39MUN+meJ5vVQTSX0Yy5pzOZ gxBZGc8GhF9vhut1/tePhBwY3TEv+pBVY7VDBJgzYb2LKjmFOQcs+PictjmciLWPeyM4 /hVg== X-Forwarded-Encrypted: i=1; AKwUvByaqJVqzM97D0IGA+s04JSa+g/XGkSwEl/XAzAOP2vxXxNAUoN1xk9w2ezROD/GAMJ+1p8QxQVoycSCnbk=@vger.kernel.org X-Gm-Message-State: AFq9FYJawa8MRUkny0LHwMr30yKSYYWRWTWZgIiz2oD+BpuimArbCuFs Vup+YpGnlCkR7/DlGV5N/aYGOy1fT4zeLEKv4jf/oS7JIvtRHEMGtO1Xdb4QJVKUEoc= X-Gm-Gg: AYBFou2OBaWBocrY/e+3iiVXjW9i9bN41EQnnLAnddquu0bhut0nTGP3mea7/Gc9H99 LB1Q0rZihYvwYkhIuYV+Dpp+lSwGBL3L1mINnHMPPvB8cHUIQR+j8aGk6wQ3sQH9Pt+Hld4IYNZ 30bPpIClvQiobAoavfJzCYL+FvwbPanGTJekHb8jYVHJgvA55rXE95EFLZPKbS+0eMbxwKaSVx1 8T8maPOcwaWQMUdTkXf4DNQDIFc06PbomPM44cCLhQeIcO2qXwbrekPUXU5lmRFUeCPKMx8bGfx wAgtp/UV9JBbRS4e6hCOKDDrK9pBbkhtdZ1vSVY4x/BPOe70PVFGZp9bW2iFxHs0prirXxvoxdf iT+vKWxDnz+zQDSiybLOPeAFlqyK5uSuwF65uGKna+PjnEsFLK3YzRZOpXk0oqu6BVh2EEZvfdu ep2yGZ82q/ixKcBn8hLZAnCP85DN6huwiM2Wb1zrbmsCWvZNH35uFVyA6q6wPJmB6i6+J7Q9Inj /D59+myUzFezE+2oJiulR22eqYDkGFqoddkIx9jMwou6g== X-Received: by 2002:a05:6214:3c86:b0:91b:5d3a:5105 with SMTP id 6a1803df08f44-91c12f580cemr1790346d6.51.1792532920531; Tue, 20 Oct 2026 14:48:40 -0700 (PDT) Received: from [192.168.86.58] (pool-173-79-60-52.washdc.fios.verizon.net. [173.79.60.52]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-91c10bc99a7sm8625276d6.22.2026.10.20.14.48.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Oct 2026 14:48:37 -0700 (PDT) X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v6 07/39] mm: assert mmap lock held, use new flags API in vm_insert_page[s] From: "Gregory Price (Meta)" To: "Lorenzo Stoakes (ARM)" Cc: Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Jann Horn , Pedro Falcato , David Hildenbrand , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jonathan Corbet , Greg Kroah-Hartman , Dennis Dalessandro , Jason Gunthorpe , Leon Romanovsky , Paul Moore , Stephen Smalley , Jaroslav Kysela , Takashi Iwai , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Usama Arif , Kiryl Shutsemau , Doug Gilbert , "James E.J. Bottomley" , "Martin K. Petersen" , Simona Vetter , Helge Deller , Sebastian Reichel , John Hubbard , Peter Xu , Masami Hiramatsu , Oleg Nesterov , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Rik van Riel , Harry Yoo , Juri Lelli , Vincent Guittot , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Arnd Bergmann , Muchun Song , Oscar Salvador , "Matthew Wilcox (Oracle)" , Jan Kara , Marc Zyngier , Oliver Upton , Catalin Marinas , Madhavan Srinivasan , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , "David S. Miller" , Andreas Larsson , Alexander Viro , Christian Brauner , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , Youngjun Park , Johannes Weiner , Qi Zheng , Shakeel Butt , Axel Rasmussen , Yuanchu Xie , Wei Xu , Chengming Zhou , Michal Hocko , Miklos Szeredi , Xu Xin , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-usb@vger.kernel.org, linux-rdma@vger.kernel.org, selinux@vger.kernel.org, linux-sound@vger.kernel.org, bpf@vger.kernel.org, linux-scsi@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, fuse-devel@lists.linux.dev, Ihor Solodrai , Bert Karwatzki In-Reply-To: <20261013-b4-mmap-prepare-vma-flag-sanify-v6-7-1aa3c9b139f9@kernel.org> References: <20261013-b4-mmap-prepare-vma-flag-sanify-v6-0-1aa3c9b139f9@kernel.org> <20261013-b4-mmap-prepare-vma-flag-sanify-v6-7-1aa3c9b139f9@kernel.org> Date: Tue, 20 Oct 2026 17:48:32 -0400 Message-Id: <179253291264.1207257.80392040365771672.b4-reply@b4> X-Mailer: b4 0.17-dev On 2026-10-13 16:04 +0100, Lorenzo Stoakes (ARM) wrote: > The existing logic asserts that an mmap write lock is held, bizarrely, by > asserting that an mmap_read_trylock() fails (which is not the same thing). > > Assert the mmap write lock here and switch to using the new VMA flags API > while here. > > Note that the vma_start_write() is explicitly broken out from > vm_flags_set() here in order to use vma_set_flags() safely. > > Signed-off-by: Lorenzo Stoakes (ARM) Reviewed-by: Gregory Price (Meta) -- Gregory Price (Meta)