From: patchwork-bot+netdevbpf@kernel.org
To: Kaifeng Wang <kaifengw@google.com>
Cc: netdev@vger.kernel.org, edumazet@google.com,
ncardwell@google.com, kuniyu@google.com, davem@davemloft.net,
kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
asml.silence@gmail.com, almasrymina@google.com,
willemb@google.com, kaiyuanz@google.com, sdf@fomichev.me,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2] tcp: reject devmem tx with fastopen and repair
Date: Fri, 23 Oct 2026 19:30:08 +0000 [thread overview]
Message-ID: <179278380806.1224496.471951523295951567.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20261019174522.55644-1-kaifengw@google.com>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 19 Oct 2026 17:45:22 +0000 you wrote:
> tcp_sendmsg_locked() enforces that devmem TX can only proceed if the
> zero-copy path is active and a valid dmabuf binding exists. However,
> subsequent branches in tcp_sendmsg_locked() can still intercept the
> message before it reaches the devmem zero-copy loop:
>
> 1. TCP Fast Open (MSG_FASTOPEN or DEFER_CONNECT):
> If TCP_FASTOPEN_CONNECT is set, the socket may have a valid dst with
> NETIF_F_SG (so zc == MSG_ZEROCOPY and binding is present), but
> tcp_sendmsg_fastopen() -> tcp_send_syn_data() will use
> copy_page_from_iter() to byte-copy from the iterator. Since iov_base
> represents dma-buf offsets rather than user virtual addresses, this
> misinterprets offsets as user pointers and copies the caller's memory
> at those addresses into the SYN packet.
>
> [...]
Here is the summary with links:
- [net,v2] tcp: reject devmem tx with fastopen and repair
https://git.kernel.org/netdev/net/c/89b9db72918b
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2026-10-23 19:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 17:45 Kaifeng Wang
2026-10-20 16:54 ` Stanislav Fomichev
2026-10-21 10:53 ` Paolo Abeni
2026-10-21 12:59 ` Eric Dumazet
2026-10-21 15:17 ` Pavel Begunkov
2026-10-21 17:15 ` Mina Almasry
2026-10-24 14:50 ` Pavel Begunkov
2026-10-23 19:30 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179278380806.1224496.471951523295951567.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=almasrymina@google.com \
--cc=asml.silence@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kaifengw@google.com \
--cc=kaiyuanz@google.com \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®