From: Qihang <q.h.hack.winter@gmail.com>
To: netdev@vger.kernel.org
Cc: steffen.klassert@secunet.com, Christian Hopps <chopps@labn.net>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>, David Ahern <dsahern@kernel.org>,
Ido Schimmel <idosch@nvidia.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v5 0/3] xfrm: fix vti tunnel device use-after-free across async crypto resumption
Date: Tue, 27 Oct 2026 02:51:32 +0000 [thread overview]
Message-ID: <1793069492.20092.6a150514dd@gmail.com> (raw)
In-Reply-To: <20261019153247.89957-1-q.h.hack.winter@gmail.com>
The findings are addressed in v7; the series changed as follows.
[High, 1/3] You are right that the decaps success exit still used
skb->dev after the reference held across the async resumption was
dropped. v7 moves that drop below gro_cells_receive() too, so both
exits now use skb->dev before the reference is released.
[Low, 3/3] Right, the queued-skb drop also fixes a pre-existing IPTFS
leak: the parse loop can jump to the drop label before the queued skbs
are delivered. v7 adds Fixes: 6c82d24336718 for it and mentions it in
the description.
[Medium, 3/3] The reference is held only while the outer skb exists. For
a parked skb that is at most one drop_time (1 s by default); the drop
timer then flushes the skb and the reference is released. The unbounded
case is the pre-existing drop-timer re-arm behaviour of the
reorder/reassembly code, which this series does not change.
pw-bot: cr
prev parent reply other threads:[~2026-10-27 2:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 15:32 Qihang
2026-10-19 15:32 ` [PATCH net v5 1/3] xfrm: run the receive callback before dropping the skb->dev reference Qihang
2026-10-22 3:34 ` netdev-bot+sashiko
2026-10-19 15:32 ` [PATCH net v5 2/3] xfrm: set the address family before the early invalid-state drop Qihang
2026-10-19 15:32 ` [PATCH net v5 3/3] xfrm: hold the tunnel device reference across the input path Qihang
2026-10-22 3:34 ` netdev-bot+sashiko
2026-10-19 15:55 ` [PATCH net v5 0/3] xfrm: fix vti tunnel device use-after-free across async crypto resumption netdev-bot+sinfo
2026-10-20 20:20 ` Jakub Kicinski
2026-10-27 2:51 ` Qihang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1793069492.20092.6a150514dd@gmail.com \
--to=q.h.hack.winter@gmail.com \
--cc=chopps@labn.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®