mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Keith Owens <kaos@ocs.com.au>
To: Alexander.Riesen@synopsys.com
Cc: kbuild-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: Announce: Kernel Build for 2.5, release 3.0 is available
Date: Wed, 05 Jun 2002 08:55:35 +1000	[thread overview]
Message-ID: <17931.1023231335@ocs3.intra.ocs.com.au> (raw)
In-Reply-To: Your message of "Tue, 04 Jun 2002 11:16:46 +0200." <20020604091646.GB29455@riesen-pc.gr05.synopsys.com>

On Tue, 4 Jun 2002 11:16:46 +0200, 
Alex Riesen <Alexander.Riesen@synopsys.com> wrote:
>Got this trying to compile 2.5.20 with Debian's gcc 2.95.4.
>Why it took the system-wide zlib.h?
>In file included from /export/home/riesen-pc0/riesen/compile/v2.5/fs/isofs/compress.c:38:
>include/linux/zlib.h:34: zconf.h: No such file or directory

In order to do separate source and object correctly, kbuild 2.5
enforces the rule that #include "" comes from the local directory,
#include <> comes from the include path.  include/linux/zlib.h
incorrectly does #include "zconf.h" instead of #include <linux/zconf.h>,
breaking the rules.

This was not detected by common-2.5.20-1 because the nostdinc check was
incomplete, common-2.5.20-2 does nostdinc correctly.  I avoid changing
the source code for kbuild 2.5, instead I workaround these incorrect
includes by adding extra_cflags() with FIXME comments to correct the
code later.  I will do a common-2.5.20-3 to workaround zlib.h, in the
meantime try this quick and dirty fix

--- 2.5.20-pristine/include/linux/zlib.h	Mon Apr 15 05:18:43 2002
+++ 2.5.20-kbuild-2.5/include/linux/zlib.h	Tue Jun  4 11:03:05 2002
@@ -31,7 +31,7 @@
 #ifndef _ZLIB_H
 #define _ZLIB_H
 
-#include "zconf.h"
+#include <linux/zconf.h>
 
 #ifdef __cplusplus
 extern "C" {



  reply	other threads:[~2002-06-04 22:55 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-06-03  2:35 Keith Owens
2002-06-03  5:31 ` Keith Owens
2002-06-03 19:22 ` [kbuild-devel] " Thomas Duffy
2002-06-03 19:31   ` Thunder from the hill
2002-06-03 19:58     ` Thomas Duffy
2002-06-03 20:06       ` Thunder from the hill
2002-06-03 21:12         ` Thomas Duffy
2002-06-04  0:19   ` Keith Owens
2002-06-04  0:29     ` Thomas Duffy
2002-06-04  4:53 ` Keith Owens
2002-06-04  9:16   ` Alex Riesen
2002-06-04 22:55     ` Keith Owens [this message]
2002-06-05  2:25       ` [kbuild-devel] " John Cowan
2002-06-05  2:38         ` Keith Owens
2002-06-05 18:13         ` Mark Mielke
2002-06-05 13:19       ` Alex Riesen
2002-06-04 13:59   ` [kbuild-devel] " Arnd Bergmann
2002-06-05 13:53   ` Keith Owens
2002-06-07  8:49     ` Keith Owens
2002-06-12 13:54       ` Keith Owens
2002-06-12 20:55         ` [kbuild-devel] " Thomas Duffy
2002-06-13  0:15           ` Keith Owens
2002-06-03  4:06 Hayden James
2002-06-03  4:14 ` Keith Owens
2002-06-03  4:51 ` Thunder from the hill

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17931.1023231335@ocs3.intra.ocs.com.au \
    --to=kaos@ocs.com.au \
    --cc=Alexander.Riesen@synopsys.com \
    --cc=kbuild-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®