From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
To: William Bright <william.bright@imd-tec.com>
Cc: Manivannan Sadhasivam <mani@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
linux-pci@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] power: sequencing: pcie-m2: Drive the Key E SDIO_RESET# signal
Date: Tue, 27 Oct 2026 17:29:01 +0530 [thread overview]
Message-ID: <179310234194.16692.5070156797811021066.b4-reply@b4> (raw)
In-Reply-To: <at9cGzb2p4VB8EfW@will-Legion-Slim-5-16APH8>
On 2026-10-26 13:56 +0000, William Bright wrote:
> On Mon, Oct 26, 2026 at 06:16:38PM +0530, Manivannan Sadhasivam wrote:
> >
> > Do we have SDIO pwrseq consumer driver in mainline?
> >
> >
>
> No. MMC still uses its own mmc-pwrseq framework.
>
> > You should not add GPIO control to the pwrseq_pcie_m2_vregs_{enable/disable}()
> > callbacks. You should create a new 'sdio-enable' and populate
> > pwrseq_unit_data->enable/disable callbacks for the SDIO_RESET# control.
>
> An sdio-enable unit wouldn't ever be called until MMC gains a consumer.
Yes.
> Should I add the unit anyway, or drop this patch until an SDIO user
> exists? Maybe I should switch to working on this first? But it looks to
> be quite a big task.
>
If there is no user, then the unit will be a dead code and we don't add dead
code in the kernel.
- Mani
prev parent reply other threads:[~2026-10-27 11:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-26 11:38 William Bright
2026-10-26 12:46 ` Manivannan Sadhasivam
2026-10-26 13:56 ` William Bright
2026-10-27 11:59 ` Manivannan Sadhasivam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179310234194.16692.5070156797811021066.b4-reply@b4 \
--to=manivannan.sadhasivam@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mani@kernel.org \
--cc=william.bright@imd-tec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®