From: "Gregory Price (Meta)" <gourry@gourry.net>
To: "David Hildenbrand (Arm)" <david@kernel.org>
Cc: Gregory Price <gourry@gourry.net>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-team@meta.com, akpm@linux-foundation.org, ziy@nvidia.com,
joshua.hahnjy@gmail.com, rakie.kim@sk.com,
ying.huang@linux.alibaba.com, honggyu.kim@sk.com,
stable@vger.kernel.org
Subject: Re: [PATCH] mm/mempolicy: recompute automatic interleave weights on memory hotplug
Date: Tue, 27 Oct 2026 10:02:25 -0400 [thread overview]
Message-ID: <179310974571.2232644.3181896214940432050.b4-reply@b4> (raw)
In-Reply-To: <13a3b600-8a87-478e-adcc-2425c75f98c6@kernel.org>
On 2026-10-27 14:04 +0100, David Hildenbrand (Arm) wrote:
> >>> + /*
> >>> + * HMAT and CXL report a node's bandwidth only when it first gains
> >>> + * memory, so recompute the weights whenever N_MEMORY changes.
> >>> + */
> >>> + wi_state_refresh();
> >>
> >> If the function fails, should we at least pr_warn_once() ?
> >>
> >
> > The only failure state is -ENOMEM, wasn't sure that was worth warning
> > on. I actually debated whether to just make this a void function.
> >
> > I don't have a strong feeling here, but happy to add a warn if you
> > prefer it.
>
> I'd assume we'd at least want to tell the world somehow that something is now
> imprecise?
>
> Or is not updating that harmless?
>
It's a potential performance regression, but if we just -ENOMEM'd a
kernel buffer to hold the weights, there's bigger issues.
I'll add a warn.
--
~Gregory
next prev parent reply other threads:[~2026-10-27 14:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-24 17:04 Gregory Price (Meta)
2026-10-26 11:19 ` David Hildenbrand (Arm)
2026-10-26 15:47 ` Gregory Price
2026-10-27 13:04 ` David Hildenbrand (Arm)
2026-10-27 14:02 ` Gregory Price (Meta) [this message]
2026-10-26 18:13 ` Joshua Hahn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179310974571.2232644.3181896214940432050.b4-reply@b4 \
--to=gourry@gourry.net \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=honggyu.kim@sk.com \
--cc=joshua.hahnjy@gmail.com \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rakie.kim@sk.com \
--cc=stable@vger.kernel.org \
--cc=ying.huang@linux.alibaba.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®