mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joas Antonio dos Santos <joasantonio108@gmail.com>
To: David Hildenbrand <david@kernel.org>
Cc: Muchun Song <muchun.song@linux.dev>,
	Oscar Salvador <osalvador@suse.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	syzbot+91e1fc35f51774c479b2@syzkaller.appspotmail.com,
	linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hugetlbfs: emit hugetlbfs_free_inode from ->destroy_inode()
Date: Thu, 29 Oct 2026 11:23:37 -0300	[thread overview]
Message-ID: <179328381770.67441.15785036410268577790@gmail.com> (raw)
In-Reply-To: <acfd9678-fa48-4610-ba90-278cab92ee9c@kernel.org>

On 10/29/26 11:45, David Hildenbrand wrote:
> Should we rename the tracepoint then?

Fair point, "free_inode" no longer matches where it fires.

I'd keep this patch as is, though, since it is tagged for stable:
the event name is visible to users in tracefs
(events/hugetlbfs/hugetlbfs_free_inode), and renaming it in stable
kernels would break existing tracing setups there just to fix the
use-after-free.

I can send a follow-up on top of it for mm-unstable that renames the
event to hugetlbfs_destroy_inode, which also matches the
hugetlbfs_evict_inode name next to it. Would that work for you, or
would you prefer the rename folded into a v2?

Thanks,
Joas

      reply	other threads:[~2026-10-29 14:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-29  2:42 Joas Antonio dos Santos
2026-10-29 10:45 ` David Hildenbrand (Arm)
2026-10-29 14:23   ` Joas Antonio dos Santos [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179328381770.67441.15785036410268577790@gmail.com \
    --to=joasantonio108@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=muchun.song@linux.dev \
    --cc=osalvador@suse.de \
    --cc=syzbot+91e1fc35f51774c479b2@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®