From: "Rob Herring (Arm)" <robh@kernel.org>
To: Michal Wilczynski <m.wilczynski@samsung.com>
Cc: linux-rockchip@lists.infradead.org,
"Simona Vetter" <simona@ffwll.ch>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
"William Qiu" <william.qiu@starfivetech.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Dmitry Baryshkov" <dmitry.baryshkov@oss.qualcomm.com>,
devicetree@vger.kernel.org, "Andy Yan" <andyshrk@163.com>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Dominique Belhachemi" <db@domibel.de>,
"Maud Spierings" <maud_spierings@murena.io>,
"Joshua Peisach" <jpeisach@ubuntu.com>,
"David Airlie" <airlied@gmail.com>,
"Marek Szyprowski" <m.szyprowski@samsung.com>,
"Robert Foss" <rfoss@kernel.org>,
"Sandy Huang" <hjc@rock-chips.com>,
"Paul Walmsley" <pjw@kernel.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"Heiko Stuebner" <heiko@sntech.de>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Chaoyi Chen" <chaoyi.chen@rock-chips.com>,
"Alexandre Ghiti" <alex@ghiti.fr>,
"Conor Dooley" <conor@kernel.org>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Yakir Yang" <kuankuan.y@gmail.com>,
"Emil Renner Berthing" <kernel@esmil.dk>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Maxime Ripard" <mripard@kernel.org>,
"Hal Feng" <hal.feng@starfivetech.com>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
dri-devel@lists.freedesktop.org,
"Xingyu Wu" <xingyu.wu@starfivetech.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Graham Markall" <hello@big-grey.co.uk>,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"Icenowy Zheng" <zhengxingda@iscas.ac.cn>,
linux-riscv@lists.infradead.org,
"Luca Ceresoli" <luca.ceresoli@bootlin.com>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>
Subject: Re: [PATCH v6 04/18] dt-bindings: soc: starfive: Add starfive,jh7110-hdmi-subsystem
Date: Thu, 29 Oct 2026 12:38:25 -0500 [thread overview]
Message-ID: <179329528881.3539981.14637229355908751610.robh@kernel.org> (raw)
In-Reply-To: <20261029-jh7110-clean-send-v6-4-759594e43acf@samsung.com>
On Thu, 29 Oct 2026 08:53:38 +0100, Michal Wilczynski wrote:
> Add the dt-binding for the StarFive JH7110 HDMI subsystem.
>
> The JH7110 HDMI IP is a monolithic block containing both the digital
> controller and analog PHY in a single register space. This binding
> defines the parent device, which holds the shared register map, and its
> two children: the PHY and the controller.
>
> The two have separate resources. The PHY takes the 24 MHz reference
> clock and provides both the pixel clock, which the VOUT clock generator
> routes on to the display controller, and the phy the controller uses.
> The controller takes its clocks from the VOUT clock generator. What
> they share is the register space, which the parent maps.
>
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com>
> ---
> .../starfive/starfive,jh7110-hdmi-subsystem.yaml | 95 ++++++++++++++++++++++
> 1 file changed, 95 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-hdmi-subsystem.yaml: Unresolvable reference: /schemas/phy/starfive,jh7110-inno-hdmi-phy.yaml#
Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-hdmi-subsystem.example.dtb: hdmi@29590000 (starfive,jh7110-hdmi-subsystem): phy: False schema does not allow {'compatible': ['starfive,jh7110-inno-hdmi-phy'], '#clock-cells': 0, 'clocks': [[4294967295]], '#phy-cells': 0, 'phandle': 2}
from schema $id: http://devicetree.org/schemas/soc/starfive/starfive,jh7110-hdmi-subsystem.yaml
Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-hdmi-subsystem.example.dtb: /example-0/soc/hdmi@29590000/phy: failed to match any schema with compatible: ['starfive,jh7110-inno-hdmi-phy']
doc reference errors (make refcheckdocs):
See https://patchwork.kernel.org/project/devicetree/patch/20261029-jh7110-clean-send-v6-4-759594e43acf@samsung.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2026-10-29 17:38 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20261029075352eucas1p28bb0b14e03ab247dfbbee4843e1332ba@eucas1p2.samsung.com>
2026-10-29 7:53 ` [PATCH v6 00/18] drm: starfive: jh7110: Enable display subsystem Michal Wilczynski
[not found] ` <CGME20261029075353eucas1p2e700f30e833a17c676488f1427d3e565@eucas1p2.samsung.com>
2026-10-29 7:53 ` [PATCH v6 01/18] drm/bridge: inno-hdmi: fix swapped HSYNC and VSYNC polarity Michal Wilczynski
[not found] ` <CGME20261029075355eucas1p190ad652b6408201a2e04bc53c2717783@eucas1p1.samsung.com>
2026-10-29 7:53 ` [PATCH v6 02/18] drm/bridge: inno-hdmi: Don't dereference a NULL drm_device on hotplug Michal Wilczynski
[not found] ` <CGME20261029075357eucas1p298e52a601217a8def1c049665c963f13@eucas1p2.samsung.com>
2026-10-29 7:53 ` [PATCH v6 03/18] dt-bindings: display: bridge: Add starfive,jh7110-inno-hdmi-controller Michal Wilczynski
[not found] ` <CGME20261029075358eucas1p111293c602fc3aac9c6a044fc41488919@eucas1p1.samsung.com>
2026-10-29 7:53 ` [PATCH v6 04/18] dt-bindings: soc: starfive: Add starfive,jh7110-hdmi-subsystem Michal Wilczynski
2026-10-29 17:38 ` Rob Herring (Arm) [this message]
2026-10-29 17:53 ` Michal Wilczynski
2026-10-29 18:30 ` Rob Herring
2026-10-29 23:06 ` Conor Dooley
[not found] ` <CGME20261029075400eucas1p2cc7aec382fc3c977927c59b3dbcc254e@eucas1p2.samsung.com>
2026-10-29 7:53 ` [PATCH v6 05/18] dt-bindings: soc: starfive: Add starfive,jh7110-vout-syscon Michal Wilczynski
[not found] ` <CGME20261029075402eucas1p1da7f497ccc2e469112e08cc58e0bb0da@eucas1p1.samsung.com>
2026-10-29 7:53 ` [PATCH v6 06/18] dt-bindings: display: verisilicon: Add starfive,jh7110-dc8200 Michal Wilczynski
[not found] ` <CGME20261029075404eucas1p22e09c9232c1c752da1ebbf37a5646c79@eucas1p2.samsung.com>
2026-10-29 7:53 ` [PATCH v6 07/18] dt-bindings: soc: starfive: Add starfive,jh7110-vout-subsystem Michal Wilczynski
[not found] ` <CGME20261029075405eucas1p14e96e784f7984e777f9cafc27a037600@eucas1p1.samsung.com>
2026-10-29 7:53 ` [PATCH v6 08/18] drm/bridge: inno-hdmi: Split probe out of bind Michal Wilczynski
[not found] ` <CGME20261029075407eucas1p1c9b0d887cafa4c3c10bb34fa3ef3c4b7@eucas1p1.samsung.com>
2026-10-29 7:53 ` [PATCH v6 09/18] drm/bridge: inno-hdmi: Allow the register map to come from a parent Michal Wilczynski
[not found] ` <CGME20261029075409eucas1p1f82d0e8137d96be1cb3d4ed4d9fd72f8@eucas1p1.samsung.com>
2026-10-29 7:53 ` [PATCH v6 10/18] drm/bridge: inno-hdmi: Add .disable platform operation Michal Wilczynski
[not found] ` <CGME20261029075411eucas1p2833ecd1e37467796e96a1031ccae27c6@eucas1p2.samsung.com>
2026-10-29 7:53 ` [PATCH v6 11/18] drm/bridge: inno-hdmi: Add .mode_valid " Michal Wilczynski
[not found] ` <CGME20261029075413eucas1p2ec058fc0817ba072b3b69b31da65dad2@eucas1p2.samsung.com>
2026-10-29 7:53 ` [PATCH v6 12/18] drm/bridge: inno-hdmi: Make the PHY configuration table optional Michal Wilczynski
[not found] ` <CGME20261029075415eucas1p26b5dc6a09999a8b85cbf3b7d333f74df@eucas1p2.samsung.com>
2026-10-29 7:53 ` [PATCH v6 13/18] drm/bridge: inno-hdmi: Make the register clock source selectable Michal Wilczynski
[not found] ` <CGME20261029075417eucas1p1a207c9f5fb843715336e388f1b55d0b8@eucas1p1.samsung.com>
2026-10-29 7:53 ` [PATCH v6 14/18] soc: starfive: Add jh7110-hdmi-subsystem driver Michal Wilczynski
[not found] ` <CGME20261029075420eucas1p1fd7d94e680ce387882517681fc6e0433@eucas1p1.samsung.com>
2026-10-29 7:53 ` [PATCH v6 15/18] soc: starfive: Add jh7110-vout-subsystem driver Michal Wilczynski
[not found] ` <CGME20261029075422eucas1p29cc276f51f970ddf96a524716c7aaf37@eucas1p2.samsung.com>
2026-10-29 7:53 ` [PATCH v6 16/18] drm/bridge: starfive: Add JH7110 HDMI controller driver Michal Wilczynski
[not found] ` <CGME20261029075424eucas1p28bafc6e97bae9a01d4af728bbe7d690e@eucas1p2.samsung.com>
2026-10-29 7:53 ` [PATCH v6 17/18] riscv: dts: starfive: jh7110: Update DT for display subsystem Michal Wilczynski
[not found] ` <CGME20261029075425eucas1p199247568ca0be9033d41404369b94f5d@eucas1p1.samsung.com>
2026-10-29 7:53 ` [PATCH v6 18/18] MAINTAINERS: Add StarFive JH7110 display subsystem entry Michal Wilczynski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179329528881.3539981.14637229355908751610.robh@kernel.org \
--to=robh@kernel.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=alex@ghiti.fr \
--cc=andrzej.hajda@intel.com \
--cc=andyshrk@163.com \
--cc=aou@eecs.berkeley.edu \
--cc=chaoyi.chen@rock-chips.com \
--cc=conor@kernel.org \
--cc=db@domibel.de \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hal.feng@starfivetech.com \
--cc=heiko@sntech.de \
--cc=hello@big-grey.co.uk \
--cc=hjc@rock-chips.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=jpeisach@ubuntu.com \
--cc=kernel@esmil.dk \
--cc=krzk+dt@kernel.org \
--cc=kuankuan.y@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=luca.ceresoli@bootlin.com \
--cc=m.szyprowski@samsung.com \
--cc=m.wilczynski@samsung.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mani@kernel.org \
--cc=maud_spierings@murena.io \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=rfoss@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=u.kleine-koenig@baylibre.com \
--cc=william.qiu@starfivetech.com \
--cc=xingyu.wu@starfivetech.com \
--cc=zhengxingda@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®