mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Lefteris Koutrakis <lefteris.koutrakis@gmail.com>
Cc: krzk@kernel.org, linuxppc-dev@lists.ozlabs.org,
	chleroy@kernel.org,  npiggin@gmail.com,
	linux-kernel@vger.kernel.org, sashiko-bot@kernel.org,
	 ritesh.list@gmail.com, conor+dt@kernel.org, mpe@ellerman.id.au,
	 devicetree@vger.kernel.org, sshegde@linux.ibm.com,
	maddy@linux.ibm.com
Subject: Re: [PATCH v2] powerpc: dts: Add support for WatchGuard Firebox T30
Date: Thu, 29 Oct 2026 12:38:29 -0500	[thread overview]
Message-ID: <179329529616.3541731.13593434719099067546.robh@kernel.org> (raw)
In-Reply-To: <20261029112742.10238-1-lefteris.koutrakis@gmail.com>


On Thu, 29 Oct 2026 07:27:41 -0400, Lefteris Koutrakis wrote:
> Add initial device tree support for the WatchGuard Firebox T30 board.
> Enable building firebox-t30.dtb under CONFIG_MPC85xx_RDB in the
> arch/powerpc/boot/dts/fsl/Makefile. Document the watchguard vendor
> prefix in vendor-prefixes.yaml.
> 
> Signed-off-by: Lefteris Koutrakis <lefteris.koutrakis@gmail.com>
> ---
>  .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
>  arch/powerpc/boot/dts/fsl/Makefile            |   1 +
>  arch/powerpc/boot/dts/fsl/firebox-t30.dts     | 386 ++++++++++++++++++
>  3 files changed, 389 insertions(+)
>  create mode 100644 arch/powerpc/boot/dts/fsl/firebox-t30.dts
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/vendor-prefixes.yaml:2022:1: [error] missing document start "---" (document-start)
./Documentation/devicetree/bindings/vendor-prefixes.yaml:2022:3: [error] syntax error: expected '<document start>', but found '<block mapping start>' (syntax)

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/vendor-prefixes.yaml: ignoring, error parsing file
./Documentation/devicetree/bindings/vendor-prefixes.yaml: error loading YAML: expected a single document in the stream
  in "./Documentation/devicetree/bindings/vendor-prefixes.yaml", line 4, column 1
but found another document
  in "./Documentation/devicetree/bindings/vendor-prefixes.yaml", line 2022, column 3
./Documentation/devicetree/bindings/vendor-prefixes.yaml:2022:3: but found another document

doc reference errors (make refcheckdocs):

See https://patchwork.kernel.org/project/devicetree/patch/20261029112742.10238-1-lefteris.koutrakis@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


      parent reply	other threads:[~2026-10-29 17:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-29 11:27 Lefteris Koutrakis
2026-10-29 11:44 ` Krzysztof Kozlowski
2026-10-29 17:38 ` Rob Herring (Arm) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179329529616.3541731.13593434719099067546.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=chleroy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk@kernel.org \
    --cc=lefteris.koutrakis@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.ibm.com \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=ritesh.list@gmail.com \
    --cc=sashiko-bot@kernel.org \
    --cc=sshegde@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®