From: William Breathitt Gray <wbg@kernel.org>
To: Danish Khateeb <danishkhateeb03@gmail.com>
Cc: William Breathitt Gray <wbg@kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] counter: Allow 32-bit tasks to use the character device
Date: Sat, 31 Oct 2026 13:58:53 -0400 [thread overview]
Message-ID: <179346935344.3644513.5332123688446379060.b4-ty@kernel.org> (raw)
In-Reply-To: <20260929012138.71156-1-danishkhateeb03@gmail.com>
On Mon, 28 Sep 2026 20:21:38 -0500, Danish Khateeb wrote:
> counter_fops has no .compat_ioctl, so COUNTER_ADD_WATCH_IOCTL,
> COUNTER_ENABLE_EVENTS_IOCTL and COUNTER_DISABLE_EVENTS_IOCTL fail with
> -ENOTTY for 32-bit tasks on a 64-bit kernel, e.g. armhf userspace on
> arm64. Without a watch, such a task gets no events from /dev/counterN.
>
> struct counter_watch has the same layout for 32-bit and 64-bit tasks,
> and the other two ioctls take no argument, so compat_ptr_ioctl() is
> enough. struct counter_event, which read() returns, has the same layout
> too.
>
> [...]
I don't believe this warrants a backport to the stable trees, so I've
dropped the respective Cc tag.
Applied, thanks!
[1/1] counter: Allow 32-bit tasks to use the character device
commit: d722f879730c766ed9347352f4b5855a4841125d
Best regards,
--
William Breathitt Gray <wbg@kernel.org>
prev parent reply other threads:[~2026-10-31 17:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 1:21 Danish Khateeb
2026-10-31 17:58 ` William Breathitt Gray [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179346935344.3644513.5332123688446379060.b4-ty@kernel.org \
--to=wbg@kernel.org \
--cc=danishkhateeb03@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®