From: Heiko Stuebner <heiko@sntech.de>
To: linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Dennis Gilmore <dennis@ausil.us>
Cc: Heiko Stuebner <heiko@sntech.de>,
Cristian Ciocaltea <cristian.ciocaltea@collabora.com>,
Alexey Charkov <alchark@gmail.com>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Rob Herring <robh@kernel.org>
Subject: Re: [PATCH] arm64: dts: rockchip: Fix adc-keys wiring for Orange Pi 5 family
Date: Sun, 1 Nov 2026 23:16:04 +0100 [thread overview]
Message-ID: <179357136490.4108155.2920979357901660151.b4-ty@b4> (raw)
In-Reply-To: <20261012033929.2317231-1-dennis@ausil.us>
On Sun, 11 Oct 2026 22:39:29 -0500, Dennis Gilmore wrote:
> When working on u-boot for the Orange Pi 5 Pro it was called out that
> the Pro does not have a recovery button and was missing the definition
> for the maskrom button.
>
> The shared rk3588s-orangepi-5.dtsi describes a "Recovery" adc-keys
> button on SARADC channel 1. This is correct for the Orange Pi 5 and
> 5B, but the Orange Pi 5 Pro schematic shows channel 1 is pulled up
> with no button ever wired to it, so the key can never be pressed.
> Each board's schematic also shows SARADC channel 0 is connected to
> a real, populated Maskrom button, but no board described it.
>
> [...]
Applied, thanks!
[1/1] arm64: dts: rockchip: Fix adc-keys wiring for Orange Pi 5 family
commit: 591ff7dda0603cf21cfe3bfd7d9b1d10be8154c1
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
prev parent reply other threads:[~2026-11-01 22:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 3:39 Dennis Gilmore
2026-11-01 22:16 ` Heiko Stuebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179357136490.4108155.2920979357901660151.b4-ty@b4 \
--to=heiko@sntech.de \
--cc=alchark@gmail.com \
--cc=conor+dt@kernel.org \
--cc=cristian.ciocaltea@collabora.com \
--cc=dennis@ausil.us \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®