From: Niklas Cassel <cassel@kernel.org>
To: dlemoal@kernel.org, linux-ide@vger.kernel.org, shao.mingyin@zte.com.cn
Cc: Niklas Cassel <cassel@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ata: pata_pxa: fix the inverted DMA completion timeout check
Date: Mon, 2 Nov 2026 17:13:22 +0100 [thread overview]
Message-ID: <179363577159.1271393.15310421750488395575.b4-ty@kernel.org> (raw)
In-Reply-To: <20261031222002591vYvH6hQ_JbuZFeV5bccF1@zte.com.cn>
On Sat, 31 Oct 2026 22:20:02 +0800, shao.mingyin@zte.com.cn wrote:
> pxa_bmdma_stop() waits for the DMA completion that pxa_ata_dma_irq()
> signals and reports a timeout when the wait fails. The condition is
> inverted: wait_for_completion_timeout() returns zero on timeout, but the
> driver prints "Timeout waiting for DMA completion!" when the return value
> is non-zero, that is when the DMA actually completed. A real timeout is
> silent.
>
> [...]
Since Linus prefers receiving untested AI patches during the merge window:
https://lore.kernel.org/lkml/CAHk-=whOCnAwXz-FMRdQEDJQ+9b2YXh9M=GHgRay0o4cxSmPVg@mail.gmail.com/
Applied to libata/linux.git (for-7.5), thanks!
[1/1] ata: pata_pxa: fix the inverted DMA completion timeout check
https://git.kernel.org/libata/linux/c/aa99a446
Kind regards,
Niklas
prev parent reply other threads:[~2026-11-02 16:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-31 14:20 shao.mingyin
2026-11-02 16:13 ` Niklas Cassel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179363577159.1271393.15310421750488395575.b4-ty@kernel.org \
--to=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shao.mingyin@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®