From: Carlos Maiolino <cem@kernel.org>
To: "Adrián García Casado" <adriangarciacasado42@gmail.com>
Cc: "Darrick J . Wong" <djwong@kernel.org>,
linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xfs: add __printf attribute to xfs_buf_alert_ratelimited()
Date: Tue, 03 Nov 2026 11:02:32 +0100 [thread overview]
Message-ID: <179370015211.413123.4983220960926610415.b4-ty@kernel.org> (raw)
In-Reply-To: <20261020195628.248878-1-adriangarciacasado42@gmail.com>
On Tue, 20 Oct 2026 21:56:28 +0200, Adrián García Casado wrote:
> xfs_printk_level() and _xfs_alert_tag() in fs/xfs/xfs_message.h are
> annotated with __printf(3, 4), but xfs_buf_alert_ratelimited() in the
> same header is missing the attribute.
>
> Because xfs_buf_alert_ratelimited() formats its variadic arguments via
> struct va_format and %pV, the compiler does not suggest the format
> attribute under -Wsuggest-attribute=format, and callers do not get
> compile-time format string checking.
>
> [...]
Applied to for-next, thanks!
[1/1] xfs: add __printf attribute to xfs_buf_alert_ratelimited()
commit: 976d3cd5b0a307881a0772f2fb8d4557c2f4994b
Best regards,
--
Carlos Maiolino <cem@kernel.org>
prev parent reply other threads:[~2026-11-03 10:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-20 19:56 Adrián García Casado
2026-10-21 9:36 ` Carlos Maiolino
2026-10-28 15:22 ` Christoph Hellwig
2026-11-03 10:02 ` Carlos Maiolino [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179370015211.413123.4983220960926610415.b4-ty@kernel.org \
--to=cem@kernel.org \
--cc=adriangarciacasado42@gmail.com \
--cc=djwong@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®