From: patchwork-bot+netdevbpf@kernel.org
To: Qingfang Deng <qingfang.deng@linux.dev>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@kernel.org,
kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
tristan@talencesecurity.com, norbert@doyensec.com, akpm@osdl.org,
paulus@ozlabs.org, Matt_Domsch@dell.com,
Brice.Goglin@ens-lyon.org, linux-ppp@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2] ppp: remove SC_MUST_COMP
Date: Thu, 05 Nov 2026 12:40:04 +0000 [thread overview]
Message-ID: <179388240480.3671757.14531262162704521616.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20261103015615.2704-1-qingfang.deng@linux.dev>
Hello:
This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Tue, 3 Nov 2026 09:56:11 +0800 you wrote:
> SC_MUST_COMP accidentally shares the same value with SC_DC_ERROR.
> PPPIOCGFLAGS combines configuration flags with transmit and receive
> state, so userspace cannot distinguish them, and a read-modify-write
> sequence can promote a decompression error into SC_MUST_COMP.
>
> With SC_MUST_COMP set, intentional or not, a fatal decompression error
> (SC_DC_FERROR) causes the receive path to silently drop the failed
> packet before delivering it to userspace. pppd therefore cannot detect
> the error and reset the compressor's state. Subsequent incoming IP and
> CCP packets hit the same check and are also dropped, preventing normal
> recovery.
>
> [...]
Here is the summary with links:
- [net,v2] ppp: remove SC_MUST_COMP
https://git.kernel.org/netdev/net-next/c/4bca33ba24db
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2026-11-05 12:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 1:56 Qingfang Deng
2026-11-05 12:32 ` Paolo Abeni
2026-11-05 12:40 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179388240480.3671757.14531262162704521616.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=Brice.Goglin@ens-lyon.org \
--cc=Matt_Domsch@dell.com \
--cc=akpm@osdl.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ppp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=norbert@doyensec.com \
--cc=pabeni@redhat.com \
--cc=paulus@ozlabs.org \
--cc=qingfang.deng@linux.dev \
--cc=tristan@talencesecurity.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®