mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: <linux-nvme@lists.infradead.org>, Yingjie Wang <1075151112@qq.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
	Sagi Grimberg <sagi@grimberg.me>,
	Marc Olson <marcolso@amazon.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nvme: avoid wrapping admin_timeout and io_timeout
Date: Fri, 6 Nov 2026 08:13:29 -0800	[thread overview]
Message-ID: <179398160932.3651019.13151076267565610184.b4-ty@kernel.org> (raw)
In-Reply-To: <tencent_1B8D08FB52E404EC3FE4933548D6CACB7305@qq.com>

On Fri, 6 Nov 2026 14:25:16 +0800, Yingjie Wang wrote:
> NVME_ADMIN_TIMEOUT and NVME_IO_TIMEOUT multiply the admin_timeout and
> io_timeout module parameters by HZ in unsigned int arithmetic, and
> nvme_fw_act_work() does the same through secs_to_jiffies(). The parameters
> accept any unsigned int, so values above UINT_MAX / HZ wrap. With HZ=1000,
> io_timeout=4294968 becomes 704 jiffies, and a controller created afterwards
> times out I/O after 0.7 seconds instead of about 49.7 days. On 32-bit
> systems, results above MAX_JIFFY_OFFSET are also unsafe relative delays and
> can be treated as already expired.
> 
> [...]

Thanks, applied to nvme-7.4.

[1/1] nvme: avoid wrapping admin_timeout and io_timeout
      commit: 4a5aeebf1a00360bcc53c9e29fcd8d47aefa4c1d
--
Keith Busch <kbusch@kernel.org>


  parent reply	other threads:[~2026-11-06 16:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06  6:25 Yingjie Wang
2026-11-06 10:32 ` Christoph Hellwig
2026-11-06 16:13 ` Keith Busch [this message]
2026-11-06 18:01 ` Olson, Marc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179398160932.3651019.13151076267565610184.b4-ty@kernel.org \
    --to=kbusch@kernel.org \
    --cc=1075151112@qq.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=marcolso@amazon.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®