mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vishal Tyagi <vishalxtyagi.oss@gmail.com>
To: dmitry.torokhov@gmail.com
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: [PATCH] Revert "Input: synaptics - enable SMBus for HP Elitebook 850 G1"
Date: Sat, 07 Nov 2026 01:10:52 +0530	[thread overview]
Message-ID: <179399405216.85438.8327280593401118083@gmail.com> (raw)

This reverts commit f04f03d3e99bc8f89b6af5debf07ff67d961bc23.

Commit f04f03d3e99b ("Input: synaptics - enable SMBus for HP Elitebook 850 G1")
added PNP ID "SYN3003" to smbus_pnp_ids[] to enable SMBus/InterTouch mode.

However, on Haswell-generation HP EliteBooks sharing this touchpad controller
(including HP EliteBook 840 G1 and HP EliteBook 850 G1), the touchpad fails
to resume after ACPI S3 suspend:

  rmi4_smbus 0-002c: failed to get SMBus version number!
  rmi4_f01 rmi4-00.fn01: Resume failed with code -6.
  rmi4_physical: Failed to resume rmi4-00: -6

Following resume from suspend, the touchpad remains completely unresponsive
and dead until a full reboot or manual module reload (modprobe -r psmouse).

Falling back to standard PS/2 mode (via synaptics_intertouch=0) allows
multi-touch gestures (two-finger scrolling, tap-to-click) to function normally
while preserving 100% reliable S3 suspend/resume behavior.

Revert this commit to prevent this regression on affected hardware.

Fixes: f04f03d3e99bc8f89b6af5debf07ff67d961bc23 ("Input: synaptics - enable SMBus for HP Elitebook 850 G1")
Cc: stable@vger.kernel.org
Signed-off-by: Vishal Tyagi <vishalxtyagi.oss@gmail.com>
---
 drivers/input/mouse/synaptics.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index a8e2a14..0d1b54a 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -195,7 +195,6 @@ static const char * const smbus_pnp_ids[] = {
 	"LEN2058", /* E490 */
 	"LEN205b", /* T490 */
 	"LEN2068", /* T14 Gen 1 */
 	"SYN1221", /* TUXEDO InfinityBook Pro 14 v5 */
-	"SYN3003", /* HP EliteBook 850 G1 */
 	"SYN3015", /* HP EliteBook 840 G2 */
 	"SYN3052", /* HP EliteBook 840 G4 */
 	"SYN3221", /* HP 15-ay000 */
-- 

                 reply	other threads:[~2026-11-06 19:40 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179399405216.85438.8327280593401118083@gmail.com \
    --to=vishalxtyagi.oss@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®