From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
To: Shawn Lin <shawn.lin@rock-chips.com>
Cc: "Sebastian Reichel" <sebastian.reichel@collabora.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Heiko Stuebner" <heiko@sntech.de>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Yury Norov (NVIDIA)" <yury.norov@gmail.com>,
"Nicolas Frattaroli" <nicolas.frattaroli@collabora.com>,
"Alexey Charkov" <alchark@flipper.net>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel@collabora.com
Subject: Re: [PATCH v8 7/9] PCI: dw-rockchip: Add pme_turn_off support
Date: Sat, 07 Nov 2026 22:02:49 +0530 [thread overview]
Message-ID: <179406916971.65886.13520937092317191699.b4-reply@b4> (raw)
In-Reply-To: <f047dcbe-efa2-4c60-8436-6d001c936467@rock-chips.com>
On 2026-11-05 08:51 +0800, Shawn Lin wrote:
> 在 2026/11/05 星期四 7:47, Sebastian Reichel 写道:
> > Prepare Rockchip PCIe controller for system suspend support by
> > adding the PME turn off operation.
> >
> > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> > ---
> > drivers/pci/controller/dwc/pcie-dw-rockchip.c | 47 +++++++++++++++++++++++++++
> > 1 file changed, 47 insertions(+)
> >
> > diff --git a/drivers/pci/controller/dwc/pcie-dw-rockchip.c b/drivers/pci/controller/dwc/pcie-dw-rockchip.c
> > index 0e26abc50920..7933c50df340 100644
> > --- a/drivers/pci/controller/dwc/pcie-dw-rockchip.c
> > +++ b/drivers/pci/controller/dwc/pcie-dw-rockchip.c
> > @@ -47,6 +47,10 @@
> > #define PCIE_CLIENT_ENABLE_LTSSM FIELD_PREP_WM16(BIT(2), 1)
> > #define PCIE_CLIENT_DISABLE_LTSSM FIELD_PREP_WM16(BIT(2), 0)
> >
> > +/* Interrupt Status Register for Received Messages */
> > +#define PCIE_CLIENT_INTR_STATUS_MSG_RX 0x04
> > +#define PME_TO_ACK BIT(9)
> > +
> > /* Interrupt Status Register Related to Legacy Interrupt */
> > #define PCIE_CLIENT_INTR_STATUS_LEGACY 0x8
> >
> > @@ -71,6 +75,11 @@
> > #define PCIE_CLKREQ_READY FIELD_PREP_WM16(BIT(0), 1)
> > #define PCIE_CLKREQ_NOT_READY FIELD_PREP_WM16(BIT(0), 0)
> > #define PCIE_CLKREQ_PULL_DOWN FIELD_PREP_WM16(GENMASK(13, 12), 1)
> > +#define PME_READY_ENTER_L23 BIT(3)
> > +
> > +/* Message Request Register */
> > +#define PCIE_CLIENT_MSG_GEN 0x34
> > +#define PME_TURN_OFF FIELD_PREP_WM16(BIT(4), 1)
> >
> > /* RASDES TBA information */
> > #define PCIE_CLIENT_CDM_RASDES_TBA_INFO_CMN 0x154
> > @@ -439,8 +448,46 @@ static int rockchip_pcie_host_init(struct dw_pcie_rp *pp)
> > return 0;
> > }
> >
> > +static void rockchip_pcie_pme_turn_off(struct dw_pcie_rp *pp)
> > +{
> > + struct dw_pcie *pci = to_dw_pcie_from_pp(pp);
> > + struct rockchip_pcie *rockchip = to_rockchip_pcie(pci);
> > + struct device *dev = rockchip->pci.dev;
> > + u32 status;
> > + int ret;
> > +
> > + /* 1. Broadcast PME_Turn_Off Message, bit 4 self-clear once done */
> > + rockchip_pcie_writel_apb(rockchip, PME_TURN_OFF, PCIE_CLIENT_MSG_GEN);
> > + ret = readl_poll_timeout(rockchip->apb_base + PCIE_CLIENT_MSG_GEN,
> > + status, !(status & BIT(4)), PCIE_PME_TO_L2_TIMEOUT_US / 10,
> > + PCIE_PME_TO_L2_TIMEOUT_US);
> > + if (ret) {
> > + dev_warn(dev, "Failed to send PME_Turn_Off\n");
> > + return;
> > + }
> > +
> > + /* 2. Wait for PME_TO_Ack, bit 9 will be set once received */
> > + ret = readl_poll_timeout(rockchip->apb_base + PCIE_CLIENT_INTR_STATUS_MSG_RX,
> > + status, status & BIT(9), PCIE_PME_TO_L2_TIMEOUT_US / 10,
> > + PCIE_PME_TO_L2_TIMEOUT_US);
> > + if (ret) {
> > + dev_warn(dev, "Failed to receive PME_TO_Ack\n");
> > + return;
> > + }
> > +
> > + /* 3. Clear PME_TO_Ack and Wait for ready to enter L23 message */
> > + rockchip_pcie_writel_apb(rockchip, PME_TO_ACK, PCIE_CLIENT_INTR_STATUS_MSG_RX);
> > + ret = readl_poll_timeout(rockchip->apb_base + PCIE_CLIENT_POWER_CON,
> > + status, status & PME_READY_ENTER_L23,
> > + PCIE_PME_TO_L2_TIMEOUT_US / 10,
> > + PCIE_PME_TO_L2_TIMEOUT_US);
> > + if (ret)
> > + dev_err(dev, "Failed to get ready to enter L23 message\n");
> > +}
>
>
> This is a question for the DWC core: should we change
> dw_pcie_host_ops::pme_turn_off() to return a value instead of silently
> ignoring a failure?
>
> Looking at pcie-designware-host.c, we have:
>
> if (pci->pp.ops->pme_turn_off) {
> pci->pp.ops->pme_turn_off(&pci->pp);
> } else {
> ret = dw_pcie_pme_turn_off(pci);
> if (ret)
> return ret;
> }
>
> The handling feels asymmetric. If ->pme_turn_off fails, shouldn't we
> abort dw_pcie_suspend_noirq as well?
>
Sure. The initial callback implementations were just broadcasing PME_Turn_off
message and didn't check for PME_To_Ack. So they ended up being void. But for
PME_To_Ack and L2/L3 Ready timeouts, we should definitely return failure and
abort suspend as the link may not enter L2/L3.
> Other than that, this patch looks good to me in current shape,
> Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>
>
> We can further discuss the callback's return value issue on top.
>
It can be done as a separate series.
- Mani
next prev parent reply other threads:[~2026-11-07 16:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 23:47 [PATCH v8 0/9] PCI: dw-rockchip: add system suspend support Sebastian Reichel
2026-11-04 23:47 ` [PATCH v8 1/9] PCI: dw-rockchip: Fix LTSSM set functions Sebastian Reichel
2026-11-04 23:47 ` [PATCH v8 2/9] PCI: dw-rockchip: Restore vpcie3v3 regulator handle Sebastian Reichel
2026-11-04 23:47 ` [PATCH v8 3/9] PCI: dw-rockchip: Move devm_phy_get out of phy_init Sebastian Reichel
2026-11-04 23:47 ` [PATCH v8 4/9] PCI: dw-rockchip: Add helper function for enhanced LTSSM control mode Sebastian Reichel
2026-11-04 23:47 ` [PATCH v8 5/9] PCI: dw-rockchip: Add helper function for controller mode Sebastian Reichel
2026-11-04 23:47 ` [PATCH v8 6/9] PCI: dw-rockchip: Add helper function for DDL indicator Sebastian Reichel
2026-11-04 23:47 ` [PATCH v8 7/9] PCI: dw-rockchip: Add pme_turn_off support Sebastian Reichel
2026-11-05 0:51 ` Shawn Lin
2026-11-05 11:38 ` Sebastian Reichel
2026-11-07 16:32 ` Manivannan Sadhasivam [this message]
2026-11-04 23:47 ` [PATCH v8 8/9] PCI: dw-rockchip: Set broken L1SS resume flag Sebastian Reichel
2026-11-04 23:47 ` [PATCH v8 9/9] PCI: dw-rockchip: Add system PM support Sebastian Reichel
2026-11-05 3:08 ` [PATCH v8 0/9] PCI: dw-rockchip: add system suspend support Igor Velkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179406916971.65886.13520937092317191699.b4-reply@b4 \
--to=manivannan.sadhasivam@oss.qualcomm.com \
--cc=alchark@flipper.net \
--cc=bhelgaas@google.com \
--cc=broonie@kernel.org \
--cc=heiko@sntech.de \
--cc=jingoohan1@gmail.com \
--cc=kernel@collabora.com \
--cc=kwilczynski@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=nicolas.frattaroli@collabora.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=shawn.lin@rock-chips.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®