From: "tip-bot2 for Zhipeng Wang" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Zhipeng Wang <zhipeng.wang_1@nxp.com>,
Thomas Gleixner <tglx@kernel.org>, Frank Li <Frank.Li@nxp.com>,
Radu Rendec <radu@rendec.net>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: irq/drivers] irqchip/imx-irqsteer: Dispose of parent IRQ mappings in remove()
Date: Mon, 09 Nov 2026 09:06:14 -0000 [thread overview]
Message-ID: <179421517455.2093942.6984969553888023835.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20261104073759.386777-4-Zhipeng.wang_1@oss.nxp.com>
The following commit has been merged into the irq/drivers branch of tip:
Commit-ID: ab8ffd7003a268b4b98004564bb1c04d98dccd79
Gitweb: https://git.kernel.org/tip/ab8ffd7003a268b4b98004564bb1c04d98dccd79
Author: Zhipeng Wang <zhipeng.wang_1@nxp.com>
AuthorDate: Wed, 04 Nov 2026 16:37:51 +09:00
Committer: Thomas Gleixner <tglx@kernel.org>
CommitterDate: Mon, 09 Nov 2026 10:01:07 +01:00
irqchip/imx-irqsteer: Dispose of parent IRQ mappings in remove()
probe() maps the parent output interrupts with irq_of_parse_and_map(),
but remove() only unchains the handlers and never disposes of those
mappings, leaking them on unbind. The child mappings handed out by the
domain are freed by their consumers and, together with the domain, are
now torn down by devres, so remove() only has to dispose of the parent
mappings it created itself.
Dispose of the parent mappings alongside the chained-handler teardown.
Fixes: 0136afa08967 ("irqchip: Add driver for imx-irqsteer controller")
Signed-off-by: Zhipeng Wang <zhipeng.wang_1@nxp.com>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Reviewed-by: Radu Rendec <radu@rendec.net>
Link: https://patch.msgid.link/20261104073759.386777-4-Zhipeng.wang_1@oss.nxp.com
---
drivers/irqchip/irq-imx-irqsteer.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/irqchip/irq-imx-irqsteer.c b/drivers/irqchip/irq-imx-irqsteer.c
index 766756e..b9ea1e8 100644
--- a/drivers/irqchip/irq-imx-irqsteer.c
+++ b/drivers/irqchip/irq-imx-irqsteer.c
@@ -272,14 +272,13 @@ out:
static void imx_irqsteer_remove(struct platform_device *pdev)
{
struct irqsteer_data *irqsteer_data = platform_get_drvdata(pdev);
- int i;
- for (i = 0; i < irqsteer_data->irq_count; i++) {
+ for (int i = 0; i < irqsteer_data->irq_count; i++) {
if (!irqsteer_data->irq[i])
break;
- irq_set_chained_handler_and_data(irqsteer_data->irq[i],
- NULL, NULL);
+ irq_set_chained_handler_and_data(irqsteer_data->irq[i], NULL, NULL);
+ irq_dispose_mapping(irqsteer_data->irq[i]);
}
irq_domain_remove(irqsteer_data->domain);
next prev parent reply other threads:[~2026-11-09 9:06 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 7:37 [PATCH v7 00/10] irqchip/imx-irqsteer: Allow building as module Zhipeng.wang_1
2026-11-04 7:37 ` [PATCH v7 01/10] irqchip/imx-irqsteer: Call chained_irq_exit() on the handler error path Zhipeng.wang_1
2026-11-08 21:49 ` [tip: irq/drivers] " tip-bot2 for Zhipeng Wang
2026-11-09 9:06 ` tip-bot2 for Zhipeng Wang
2026-11-04 7:37 ` [PATCH v7 02/10] irqchip/imx-irqsteer: Validate IRQ count before creating domain Zhipeng.wang_1
2026-11-08 21:49 ` [tip: irq/drivers] " tip-bot2 for Fabio Estevam
2026-11-09 3:31 ` Borislav Petkov
2026-11-09 4:12 ` Radu Rendec
2026-11-09 9:06 ` tip-bot2 for Fabio Estevam
2026-11-04 7:37 ` [PATCH v7 03/10] irqchip/imx-irqsteer: Dispose of parent IRQ mappings in remove() Zhipeng.wang_1
2026-11-08 21:49 ` [tip: irq/drivers] " tip-bot2 for Zhipeng Wang
2026-11-09 9:06 ` tip-bot2 for Zhipeng Wang [this message]
2026-11-04 7:37 ` [PATCH v7 04/10] irqchip/imx-irqsteer: Convert to devm_pm_runtime_set_active_enabled() Zhipeng.wang_1
2026-11-08 21:49 ` [tip: irq/drivers] " tip-bot2 for Zhipeng Wang
2026-11-09 9:06 ` tip-bot2 for Zhipeng Wang
2026-11-04 7:37 ` [PATCH v7 05/10] irqchip/imx-irqsteer: Mask all interrupts in probe() Zhipeng.wang_1
2026-11-08 21:49 ` [tip: irq/drivers] " tip-bot2 for Zhipeng Wang
2026-11-09 9:06 ` tip-bot2 for Zhipeng Wang
2026-11-04 7:37 ` [PATCH v7 06/10] irqchip/imx-irqsteer: Let devres own the clock Zhipeng.wang_1
2026-11-08 21:49 ` [tip: irq/drivers] " tip-bot2 for Zhipeng Wang
2026-11-09 9:06 ` tip-bot2 for Zhipeng Wang
2026-11-04 7:37 ` [PATCH v7 07/10] irqchip/imx-irqsteer: Allow building as module Zhipeng.wang_1
2026-11-08 21:49 ` [tip: irq/drivers] " tip-bot2 for Jindong Yue
2026-11-09 9:06 ` tip-bot2 for Jindong Yue
2026-11-04 7:37 ` [PATCH v7 08/10] irqchip/imx-irqsteer: Dispose of child IRQ mappings in remove() Zhipeng.wang_1
2026-11-08 20:24 ` Radu Rendec
2026-11-08 21:49 ` [tip: irq/drivers] " tip-bot2 for Zhipeng Wang
2026-11-09 9:06 ` tip-bot2 for Zhipeng Wang
2026-11-04 7:37 ` [PATCH v7 09/10] genirq/irqdomain: Add devm_irq_domain_create_linear() Zhipeng.wang_1
2026-11-08 21:49 ` [tip: irq/drivers] " tip-bot2 for Zhipeng Wang
2026-11-09 9:06 ` tip-bot2 for Zhipeng Wang
2026-11-04 7:37 ` [PATCH v7 10/10] irqchip/imx-irqsteer: Use devm_irq_domain_create_linear() Zhipeng.wang_1
2026-11-08 20:30 ` Radu Rendec
2026-11-08 21:49 ` [tip: irq/drivers] " tip-bot2 for Zhipeng Wang
2026-11-09 9:06 ` tip-bot2 for Zhipeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179421517455.2093942.6984969553888023835.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=Frank.Li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=radu@rendec.net \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
--cc=zhipeng.wang_1@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®