mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lee Jones <lee@kernel.org>
To: raoxu <raoxu@uniontech.com>
Cc: pavel@kernel.org, griffin@kroah.com, Denis.Osterland@diehl.com,
	linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH] leds: pwm: Fix active-low brightness with default-state keep
Date: Wed, 18 Nov 2026 19:56:02 +0000	[thread overview]
Message-ID: <179442106213.44545.9829809278369376980@kernel.org> (raw)
In-Reply-To: <9524E319B9AF9D1A+20261109085822.3755803-1-raoxu@uniontech.com>

On Mon, 09 Nov 2026, raoxu wrote:

> From: Xu Rao <raoxu@uniontech.com>
>
> With default-state set to "keep", led_pwm_add() derives the initial
> brightness from the PWM duty cycle without accounting for active-low
> LEDs. However, led_pwm_set() inverts the duty cycle for these LEDs.
>
> For an enabled active-low PWM with zero duty cycle, the LED is fully
> on but its cached brightness is set to zero. Conversely, a full duty
> cycle is reported as maximum brightness instead of off. This exposes
> an incorrect brightness to userspace and can restore the wrong value
> after suspend. With an optional enable GPIO, the incorrect brightness
> also causes the wrong initial GPIO level to be selected.
>
> Invert the computed brightness for active-low LEDs, matching the
> conversion used by led_pwm_set() while leaving the PWM state intact.
>
> The supplied fix was reviewed and this commit message prepared with
> OpenCode AI assistance.

This should not end up in the commit message.

If you want it, move it under the '---'.

> Fixes: 3d3d65bd2764 ("leds: pwm: add support for default-state device property")
> Signed-off-by: Xu Rao <raoxu@uniontech.com>
> Cc: stable@vger.kernel.org
> ---
>  drivers/leds/leds-pwm.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/leds/leds-pwm.c b/drivers/leds/leds-pwm.c
> index 6c1f2f50ff85..da307767dbe8 100644
> --- a/drivers/leds/leds-pwm.c
> +++ b/drivers/leds/leds-pwm.c
> @@ -131,6 +131,8 @@ static int led_pwm_add(struct device *dev, struct led_pwm_priv *priv,
>  		brightness = led->max_brightness;
>  		brightness *= led_data->pwmstate.duty_cycle;
>  		do_div(brightness, led_data->pwmstate.period);
> +		if (led_data->active_low)
> +			brightness = led->max_brightness - brightness;

One from the bot:

  What happens if 'pwm_get_state()' returns a state where
  '!led_data->pwmstate.enabled' or 'duty_cycle > period' from the
  bootloader/hardware?  Should we check 'led_data->pwmstate.enabled'
  before deriving a non-zero brightness for an active-low LED with
  'duty_cycle == 0'?

>  		led_data->cdev.brightness = brightness;
>  		}
>  		break;
> --
> 2.50.1
>

-- 
Lee Jones

      reply	other threads:[~2026-11-18 19:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-09  8:58 raoxu
2026-11-18 19:56 ` Lee Jones [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179442106213.44545.9829809278369376980@kernel.org \
    --to=lee@kernel.org \
    --cc=Denis.Osterland@diehl.com \
    --cc=griffin@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@kernel.org \
    --cc=raoxu@uniontech.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®