From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794468304; b=Mv/gbbXAM8hd5g1DwmAKR4cxe/iWe9jE3QlUfTv/l5Iw9iAx7jokjv0ZL8e8gIA4AIaC DJbkgXWUeHD86J7VJvT8KJfsfiNyDD0mMdGBVUIUKnIq8LLna09xz21FJb4ojPwY+xElW 5A5qLAy1CSQE8pdQ1MkORFNnmJUVM4XcvdcAPeGvyQHYTisCMa7qG5K16CcWsaAb4MsCl KhVWjeLVyAt/J3W7dPBV8ka8ITg+fHB8gZK/RDwoanQ5Wch+3w8TWDy7YJQvhfmvxDnEf wru6447LqOchH95DYn23DSqQHfcPe/L37deig+ob1xoT8SWO4UpUHJAL/nUbhL67qkQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794468304; h=Received:DKIM-Signature:Subject:From:To:Cc:Date:Message-ID: In-Reply-To:References:X-sashiko-severity:Content-Type: Content-Transfer-Encoding:MIME-Version; bh=a1xEK6Aga3yjCNS1Hmlu8sGRBKzLE3yolmU5IVLWK9g=; b=iQqUyTCzqqOYxKe+ZzAyL7dRvByOdGmLM0gqkqX9xXh+DBZG9Nb9b/6MI+OZjKgUKvQE 2PrVW70dqQ9gnq8x0+kG9irx9VPw649MVkxxYTDXZ4p3nvXUFd9JMKbyfMMsDnuDLj5bJ nBK8C/ahNDy6b502LZyKLK5mLQCKK3XHe3sNMLH8gS/couo/VYo7cgq9LC2cM+R12t6PB 3+La3er7oLpb6o/e1jO6UmOkFrndyAsnr3Qy7mqbKa1DJpNtnV4LfNKxtzSFSKFnXkqpg hGBbEAAxCcYFdbSctBo2gCekOn45YnB9dJjM7KI3uaGfCeGFchh5OaTQI1OczcM7yRA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b="jYd/fAZz"; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4233606A33D; Thu, 12 Nov 2026 07:25:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=jYd/fAZz Received: by smtp.kernel.org (Postfix) with ESMTPSA id BCABA1F00A05; Thu, 12 Nov 2026 07:25:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794468304; bh=a1xEK6Aga3yjCNS1Hmlu8sGRBKzLE3yolmU5IVLWK9g=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=jYd/fAZzm3pNLz3fQRYz76G0ehETIQ1m4H5F5RwgD5a5V/lt8BdhrdeqEUQ8DrKzx 5Lm/FRO0U6X7Onjr+NZLtQHmdJ9ja0FHhIy1RkskBrSOcRr9vNkmTVZspK4JLV4uMt 8/eIzPHtw+eHGdO3q2Gfnz5uYplSF2TLUk4eAHssQV2zNdjMRbOOESIz1I5njrPCdZ nzChP00C8o3u/dr9voat0JXLcVqm7c/t1+V3g7dM5lTjv9/vIW3ciP2Qfe23xM5xyO kPhovEsTMClfGYhNs51SrAFMd9/+pKnPuHSym9kHcY7uil/x+RAvJ8MhFoRVMngQN2 cGxWUKLdAT/cA== Subject: Re: [PATCH net-next 1/3] dt-bindings: mfd: syscon: add ti,am654-gtc From: netdev-bot+sashiko@kernel.org To: jjc@jclark.com Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org, pabeni@redhat.com, richardcochran@gmail.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, lee@kernel.org, s-vadapalli@ti.com, rogerq@kernel.org, bigeasy@linutronix.de, martin.kaistra@linutronix.de, vadim.fedorenko@linux.dev, r-sharma3@ti.com, robertcnelson@gmail.com, nm@ti.com, vigneshr@ti.com, c-vankar@ti.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, mfd@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Date: Thu, 12 Nov 2026 07:25:02 +0000 Message-ID: <179446830222.2199510.13606408467624966277@kernel.org> In-Reply-To: <42bbc4a03679958f2ed4e195acea99fb57c68fd6.1794284248.git.jjc@jclark.com> References: <42bbc4a03679958f2ed4e195acea99fb57c68fd6.1794284248.git.jjc@jclark.com> X-sashiko-severity: Low Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Thank you for your contribution! Sashiko AI review found more severe issue(s) in other patches of this series. This mail is only an FYI, in case you want to address the nit picks below when you respin. Low priority / nit picks for your consideration: - [Low] The new compatible "ti,am654-gtc" (Documentation/devicetree/bindings/mfd/syscon.yaml, line 134) is named… - [Low] The subject line "dt-bindings: mfd: syscon: add ti,am654-gtc" starts the description after the prefix with a lowercase "add". -- dt-bindings: mfd: syscon: add ti,am654-gtc This adds a ti,am654-gtc compatible to the generic syscon binding. It is for the CFG0 register frame of the TI K3 Global Timebase Counter. The CPTS driver writes GTC_CFG0_PUSHEVT in that frame to pick the counter bit the GTC exports as its push event, which provides hardware cross-timestamps. > dt-bindings: mfd: syscon: add ti,am654-gtc [Severity: Low] This isn't a bug, but MFD subjects normally capitalize the description after the prefix. Recent commits to syscon.yaml do this, for example: dt-bindings: mfd: syscon: Add ESWIN EIC7700 compatible Should this be "dt-bindings: mfd: syscon: Add ti,am654-gtc"? > diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml > index 80ff0e1caca22..b1030f11b2dbf 100644 > --- a/Documentation/devicetree/bindings/mfd/syscon.yaml > +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml > @@ -131,6 +131,7 @@ properties: > - ti,am625-dss-oldi-io-ctrl > - ti,am62p-cpsw-mac-efuse > - ti,am654-dss-oldi-io-ctrl > + - ti,am654-gtc [Severity: Low] Is ti,am654-gtc the right name for this node? The commit message says it describes only "the CFG0 register frame" of the GTC. The compatible, though, is named after the whole GTC IP. The GTC has more than one register frame. k3-am62l.dtsi maps a 0x34000-byte window for it: arch/arm64/boot/dts/ti/k3-am62l.dtsi: ranges = <0x00 0x00a80000 0x00 0x00a80000 0x00 0x00034000>, /* GTC */ The generic syscon schema allows only one register region and no extra properties: reg: maxItems: 1 [ ... ] unevaluatedProperties: false So a node with this compatible can never describe the other GTC frames or resources. The syscon.yaml description also says syscon is for registers that are "not cohesive enough to represent as any specific type of device". The GTC is a specific counter IP, and PUSHEVT is one of its own functions. Compatibles become DT ABI once merged. A full GTC binding added later would then need a different name for the same IP. Would a frame-specific name such as ti,am654-gtc-cfg0, or a dedicated GTC binding, describe the hardware more accurately? The ti,gtc-push property in ti,k3-am654-cpts.yaml, added later in the series, also describes its target as only the GTC CFG0 syscon. No later patch in the series changes syscon.yaml, so the naming is the same at the end of the series. -- Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/cover.1794284248.git.jjc%40jclark.com