From: Arun Iyengar <aiyengar1990@gmail.com>
To: MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Boris Brezillon <boris.brezillon@collabora.com>,
Steven Price <steven.price@arm.com>,
Liviu Dudau <liviu.dudau@arm.com>,
Jonas Karlman <jonas@kwiboo.se>
Subject: Re: [PATCH] PM / devfreq: Do not change the frequency of a suspended device
Date: Fri, 13 Nov 2026 20:34:27 -0000 [thread overview]
Message-ID: <179460206763.199714.13518791714665074913@gmail.com> (raw)
In-Reply-To: <20261112-devfreq-suspend-sync-v1-1-af64603ef43e@gmail.com>
Please don't apply this version. The Sashiko review found bugs in it:
- A limit change on a suspended passive device stores 0 in
pending_freq, so devfreq_resume_device() can then fail with -EINVAL.
- After a deferred update, resume asks the governor instead of
restoring resume_freq, so a userspace governor without set_freq
stays at the suspend OPP.
- Two error paths leave the device marked suspended or skip
DEVFREQ_GOV_RESUME.
- The passive question in the cover: exynos-bus children need to
follow their parent to its suspend OPP, also at shutdown.
v2 will fix these.
Arun
prev parent reply other threads:[~2026-11-13 20:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 8:06 Arun Iyengar via B4 Relay
2026-11-13 20:34 ` Arun Iyengar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179460206763.199714.13518791714665074913@gmail.com \
--to=aiyengar1990@gmail.com \
--cc=boris.brezillon@collabora.com \
--cc=cw00.choi@samsung.com \
--cc=jonas@kwiboo.se \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=myungjoo.ham@samsung.com \
--cc=steven.price@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®