From: Hongyan Xu <getshell@seu.edu.cn>
To: "Rong Zhang" <i@rong.moe>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Zehao Gao <gaozehao@iie.ac.cn>, Hyunjung <hj351016@gmail.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Derek J. Clark <derekjohn.clark@gmail.com>,
Mark Pearson <mpearson-lenovo@squebb.ca>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] extcon: synchronize all-connector removal and fix Lenovo fastcharger teardown
Date: Mon, 16 Nov 2026 22:30:46 +0800 [thread overview]
Message-ID: <179483944681.43652.9539572356847924730@seu.edu.cn> (raw)
In-Reply-To: <179474326098.103840.15531040789536968458@seu.edu.cn>
Hi Rong, Ilpo,
Thanks for the review, and sorry for the mess. Let me answer the questions, and also put one thing on the record about where the extcon part came from, because the timeline matters here.
v1 link: https://msgid.link/20260806060526.1189-1-getshell@seu.edu.cn
That is the patch I posted on 2026-08-06. I should have put it in the cover letter - my mistake.
Why the extcon patch exists at all, and why it is in this series:
v1 only cancelled the work inside the lenovo driver (devm_work_autocancel). After sending it I went back over the teardown path and realized the patch itself was not correct: cancelling the work is not enough, because the all-connector raw notifier in extcon can still be running a callback after the consumer unregistered, and that callback can publish the work again. So the root cause sits in extcon's notifier handling, and that is what 1/2 fixes. That is also why 2/2 says it depends on the preceding synchronization patch.
On the origin of the idea - I understand the suspicion, so here are the dates:
My v1 is from 2026-08-06 (link above). It is also the patchset referenced by the Closes: link Ilpo posted in the 1/2 thread.
sashiko reviewed that patchset back then and raised exactly this "extcon uses raw notifiers, the synchronization is insufficient" concern. I never received that report in my mailbox; I first learned about it from Ilpo's reply on 2026-11-09:
https://lore.kernel.org/all/2ef4ad43-497f-c40f-b18a-f5b75799d95d@linux.intel.com/
That is why 1/2 carries a Link: to that message.
Hyunjung's patch is from 2026-11-16:
https://msgid.link/20261116122001.3096223-1-hj351016@gmail.com
i.e. three months later.
So this did not come from Hyunjung's patch; if anything the order is the other way round. I am not trying to win an argument - I just do not want the record to say I took someone else's work.
The attribution Ilpo suggested is right, and I will use it:
Reported-by: Sashiko <sashiko-bot@kernel.org>
Closes: https://sashiko.dev/#/patchset/20260806060526.1189-1-getshell%40seu.edu.cn
On the other points - all fair, all my fault:
S-o-b order: fixed. Zehao Gao co-audited this series with me, so his Signed-off-by comes first and mine (the submitter) last:
Signed-off-by: Zehao Gao <gaozehao@iie.ac.cn>
Signed-off-by: Hongyan Xu <getshell@seu.edu.cn>
The mangled "Jarvinen": my git-send-email setup on Windows encoded the Cc display names as GBK instead of UTF-8. Fixed now (i18n.commitEncoding=utf-8, sendemail encoding, UTF-8 console), and I checked the headers of a test message before posting. Sorry for the noise, and thanks for fixing my Cc line.
On Ilpo's point that the extcon fix is not pdx86 material - agreed. I will take 1/2 out of this series; if the extcon change is still wanted, I will repost it to the extcon list on its own with the attribution above. And since Hyunjung is already working on this, I am happy to let her series go first - if her approach covers it, mine can be dropped entirely.
Although I do not have the hardware, the change has been build-tested and manually audited. The analysis and the patch text were produced with LLM assistance, then reviewed and edited by me.
Thanks,
Hongyan
next prev parent reply other threads:[~2026-11-16 14:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-15 11:47 Hongyan Xu
2026-11-15 11:47 ` [PATCH v2 1/2] extcon: synchronize all-connector notifier removal Hongyan Xu
2026-11-16 11:28 ` Ilpo Järvinen
2026-11-15 11:47 ` [PATCH v2 2/2] platform/x86: lenovo: cancel fastcharger work on detach Hongyan Xu
2026-11-16 12:59 ` Rong Zhang
2026-11-16 13:29 ` Ilpo Järvinen
2026-11-16 12:58 ` [PATCH v2 0/2] extcon: synchronize all-connector removal and fix Lenovo fastcharger teardown Rong Zhang
2026-11-16 14:30 ` Hongyan Xu [this message]
2026-11-16 16:58 ` Rong Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179483944681.43652.9539572356847924730@seu.edu.cn \
--to=getshell@seu.edu.cn \
--cc=cw00.choi@samsung.com \
--cc=derekjohn.clark@gmail.com \
--cc=gaozehao@iie.ac.cn \
--cc=hj351016@gmail.com \
--cc=i@rong.moe \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpearson-lenovo@squebb.ca \
--cc=myungjoo.ham@samsung.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®