From: Keith Busch <kbusch@kernel.org>
To: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
Mani Tofigh <mt4022@columbia.edu>
Cc: <linux-nvme@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
<tz2294@columbia.edu>, <stable@vger.kernel.org>
Subject: Re: [PATCH] nvme: fix deadlock on nvme_subsystems_lock in nvme_init_subsystem()
Date: Mon, 16 Nov 2026 08:18:29 -0800 [thread overview]
Message-ID: <179484590948.648177.11478558432754935680.b4-ty@kernel.org> (raw)
In-Reply-To: <20261111-nvme-subsys-lock-deadlock-v1-1-1837b8e9076f@columbia.edu>
On Wed, 11 Nov 2026 17:46:31 -0500, Mani Tofigh wrote:
> Connecting a controller to a new subsystem deadlocks when
> sysfs_create_link() fails in nvme_init_subsystem(), e.g., on an
> allocation failure. The error path drops the last subsystem reference
> with nvme_subsystems_lock held and nvme_destroy_subsystem() takes the
> same lock again:
>
> nvme nvme0: failed to create sysfs link from subsystem.
> ============================================
> WARNING: possible recursive locking detected
> ...
> nvmesubsys/95 is trying to acquire lock:
> (nvme_subsystems_lock){+.+.}-{4:4}, at: nvme_destroy_subsystem+0x1b/0x1e0
>
> [...]
Thanks, applied to nvme-7.4.
[1/1] nvme: fix deadlock on nvme_subsystems_lock in nvme_init_subsystem()
commit: ba1213be15c613a1c03db69ea6480ca140a6ca00
--
Keith Busch <kbusch@kernel.org>
prev parent reply other threads:[~2026-11-16 16:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 22:46 Mani Tofigh via B4 Relay
2026-11-12 21:08 ` Christoph Hellwig
2026-11-16 16:18 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179484590948.648177.11478558432754935680.b4-ty@kernel.org \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mt4022@columbia.edu \
--cc=sagi@grimberg.me \
--cc=stable@vger.kernel.org \
--cc=tz2294@columbia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®