mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hunter Laux <hunterlaux@gmail.com>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Linus Walleij <linusw@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Paul Cercueil <paul@crapouillou.net>,
	Bartosz Golaszewski <brgl@kernel.org>,
	linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
	letux-kernel@openphoenux.org
Subject: Re: [PATCH 3/3] pinctrl: ingenic: Add X2600 pin groups and functions
Date: Mon, 16 Nov 2026 18:17:55 -0700	[thread overview]
Message-ID: <179487827555.2153459.1199232821591145638@gmail.com> (raw)
In-Reply-To: <afd42cc2ca2c93501ff1769b7d7a25559ef68a2f.1794557697.git.hns@goldelico.com>

Hi Nikolaus,

On Fri, Nov 13, 2026 at 09:14:58AM +0100, H. Nikolaus Schaller wrote:
> +	INGENIC_PIN_GROUP("uart1-data-c", x2600_uart1_data_c, 1),
> +	INGENIC_PIN_GROUP("uart2-data", x2600_uart2_data, 1),
> +	INGENIC_PIN_GROUP("uart4-data-b", x2600_uart4_data_b, 2),
> +	INGENIC_PIN_GROUP("uart5-data-b", x2600_uart5_data_b, 2),

Per the X2600 PM, shouldn't these be 2, 0, 1 and 1?

> +static int x2600_slcd_ctrl_pins[] = {
> +	0x34, 0x3c, 0x3d, 0x3e, 0x3f,
> +};

PB20 (0x34) has no function 1. Did this come from the X2000 table?
Should 0x34 be dropped?

> +	INGENIC_PIN_GROUP("pcm", x2600_pcm, 3),
[...]
> +	INGENIC_PIN_GROUP("pwm11", x2600_pwm11, 0),
> +	INGENIC_PIN_GROUP("pwm12", x2600_pwm12, 0),
> +	INGENIC_PIN_GROUP("pwm13", x2600_pwm13, 0),
> +	INGENIC_PIN_GROUP("pwm14", x2600_pwm14, 0),
> +	INGENIC_PIN_GROUP("pwm15", x2600_pwm15, 0),
> +	INGENIC_PIN_GROUP("pwm-trig-c", x2600_pwm_trig_c, 1),
> +	INGENIC_PIN_GROUP("pwm-trig-d", x2600_pwm_trig_d, 1),
[...]
> +	INGENIC_PIN_GROUP("wait", x2600_wait, 3),

These groups aren't in any function.

> +	0x000007ff, 0xffffffff, 0x7ffbfff, 0x0000ffff, 0x000ffffe,
[...]
> +	0x000007ff, 0xffffffff, 0x01ffff1, 0x0001e000, 0x000fffff,

Port C is missing a digit?

On port E, 0x80 is pull enable and 0x90 selects up/down (PEPE/PEPS).
Doesn't that make the X2000 pull code wrong there?

Hunter

      reply	other threads:[~2026-11-17  1:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13  8:14 [PATCH 0/3] pinctrl: ingenic: Add X2600 support H. Nikolaus Schaller
2026-11-13  8:14 ` [PATCH 1/3] dt-bindings: " H. Nikolaus Schaller
2026-11-13 17:20   ` Conor Dooley
2026-11-13  8:14 ` [PATCH 2/3] pinctrl: ingenic: Add X2600 register and GPIO IRQ support H. Nikolaus Schaller
2026-11-13  9:37   ` Paul Cercueil
2026-11-13  9:49     ` H. Nikolaus Schaller
2026-11-13  9:54       ` Paul Cercueil
2026-11-13 10:02         ` H. Nikolaus Schaller
2026-11-13 12:42           ` H. Nikolaus Schaller
2026-11-16 17:18             ` Paul Cercueil
2026-11-16 17:29               ` H. Nikolaus Schaller
2026-11-13  8:14 ` [PATCH 3/3] pinctrl: ingenic: Add X2600 pin groups and functions H. Nikolaus Schaller
2026-11-17  1:17   ` Hunter Laux [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179487827555.2153459.1199232821591145638@gmail.com \
    --to=hunterlaux@gmail.com \
    --cc=brgl@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hns@goldelico.com \
    --cc=krzk+dt@kernel.org \
    --cc=letux-kernel@openphoenux.org \
    --cc=linusw@kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=paul@crapouillou.net \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®