mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Muhammad Haris Awan <m.harisawan@icloud.com>
To: David Hildenbrand <david@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Kees Cook <kees@kernel.org>, Lorenzo Stoakes <ljs@kernel.org>,
	Liam R. Howlett <liam@infradead.org>,
	Vlastimil Babka <vbabka@kernel.org>,
	Mike Rapoport <rppt@kernel.org>,
	Suren Baghdasaryan <surenb@google.com>,
	Michal Hocko <mhocko@suse.com>,
	Juri Lelli <juri.lelli@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
	Valentin Schneider <vschneid@redhat.com>,
	K Prateek Nayak <kprateek.nayak@amd.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH] fork: mark memcpy() in dup_mm() with data_race()
Date: Tue, 17 Nov 2026 15:24:51 +0500	[thread overview]
Message-ID: <179491109101.4015489.11185824873441987133@icloud.com> (raw)
In-Reply-To: <0b565b9c-1462-4fed-8836-9a7d08e4b861@kernel.org>

Hi David,

Reclaim isn't touching the new mm being initialized (which isn't added to
mm_list->fifo until lru_gen_add_mm() at the end of copy_process()).

The KCSAN read is on oldmm inside dup_mm()'s memcpy(mm, oldmm, sizeof(*mm)):
oldmm is an already-live mm sitting on mm_list->fifo, so when an adjacent
exiting mm calls lru_gen_del_mm(), list_del_init() updates
oldmm->lru_gen.list.next/.prev under mm_list->lock.

Since oldmm is live, lru_gen_del_mm() has to update those list pointers.
The alternatives in dup_mm() would be taking mm_list->lock (plus
mmlist_lock) during fork, or avoiding copying oldmm->lru_gen / oldmm->mmlist
(awkward because struct mm_struct uses __randomize_layout). Wrapping the
memcpy() in data_race() avoids locking on fork and matches dup_vma() in
mm/vma_init.c.

Thanks,
Muhammad Haris Awan

  reply	other threads:[~2026-11-17 10:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  5:59 Muhammad Haris Awan
2026-11-17  8:59 ` David Hildenbrand (Arm)
2026-11-17 10:24   ` Muhammad Haris Awan [this message]
2026-11-17 10:54     ` David Hildenbrand (Arm)
2026-11-17 13:02       ` Lorenzo Stoakes (ARM)
2026-11-17 14:26         ` Muhammad Haris Awan
2026-11-17 12:58 ` Lorenzo Stoakes (ARM)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179491109101.4015489.11185824873441987133@icloud.com \
    --to=m.harisawan@icloud.com \
    --cc=akpm@linux-foundation.org \
    --cc=bsegall@google.com \
    --cc=david@kernel.org \
    --cc=dietmar.eggemann@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=kees@kernel.org \
    --cc=kprateek.nayak@amd.com \
    --cc=liam@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=mgorman@suse.de \
    --cc=mhocko@suse.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=rppt@kernel.org \
    --cc=surenb@google.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=vbabka@kernel.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®