mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Spandan Barve <spandan567@gmail.com>
To: Jamil Khan <khanjamilahmed202@gmail.com>
Cc: "Joshua Grisham" <josh@joshuagrisham.com>,
	"Hans de Goede" <hansg@kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86: samsung-galaxybook: Re-enable ACPI features on resume
Date: Tue, 17 Nov 2026 21:06:58 +0530	[thread overview]
Message-ID: <179492981820.29200.9583804047448815059@gmail.com> (raw)
In-Reply-To: <20261112165433.64461-1-khanjamilahmed202@gmail.com>

Hi Jamil,

Same problem here on another model: Galaxy Book5 Pro 940XHA (SAM0430,
Core Ultra 7 258V, BIOS P07VAJ.330.250516.01), on Arch's linux-zen
7.3.4. I applied your patch to the 7.3.4 driver source (it applies with
offsets), built it out-of-tree and loaded it in place of the stock
module. Hibernation goes to a swap file via systemctl hibernate.

With the stock module, after one hibernate/restore cycle:

  $ cat /sys/class/power_supply/BAT1/charge_control_end_threshold
  cat: /sys/class/power_supply/BAT1/charge_control_end_threshold: No such device or address
  $ wc -c < /sys/class/power_supply/BAT1/uevent
  0
  $ cat /sys/class/firmware-attributes/samsung-galaxybook/attributes/power_on_lid_open/current_value
  cat: [...]/power_on_lid_open/current_value: No such device or address

and right after "PM: hibernation: hibernation exit" the log has 50 of

  acpi SAM0430:00: failed to execute CSFI; device responded with failure code 0xff
  power_supply BAT1: driver failed to report `charge_control_end_threshold' property: -6

They keep coming for as long as something reads the battery: an earlier
boot on 7.2.15 logged 5443 of them.

With the patch, over two hibernate/restore cycles and one s2idle cycle,
charge_control_end_threshold still reads 80, BAT1/uevent is complete,
power_on_lid_open and usb_charging read back, and there are no CSFI
errors or other new messages after resume. platform_profile works with
and without the patch, as you noted.

Tested-by: Spandan Barve <spandan567@gmail.com>

      reply	other threads:[~2026-11-17 15:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-12 16:54 Jamil Khan
2026-11-17 15:36 ` Spandan Barve [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179492981820.29200.9583804047448815059@gmail.com \
    --to=spandan567@gmail.com \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=josh@joshuagrisham.com \
    --cc=khanjamilahmed202@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®