From: netdev-bot+sashiko@kernel.org
To: claudiu.manoil@nxp.com
Cc: netdev@vger.kernel.org, s32@nxp.com, bhelgaas@google.com,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
kuba@kernel.org
Subject: Re: [PATCH net-next v4 6/6] PCI: Create OF node for NXP ENETC pseudo-MAC functions
Date: Tue, 17 Nov 2026 15:55:12 +0000 [thread overview]
Message-ID: <179493091275.3136.9482657927785539194@kernel.org> (raw)
In-Reply-To: <e256f380f2f1bc88752ee261101cc83ad84ebedd.1794581338.git.claudiu.manoil@nxp.com>
Thank you for your contribution! Sashiko AI review found 2 potential
issue(s) to consider.
Critical: 0 · High: 0 · Medium: 1 · Low: 1
If you believe none of the issues are legitimate, please reply to each
issue of Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply
(one such reply per series is enough).
- [Medium] The two new fixups for 0xe101 and 0xe110 in
drivers/pci/quirks.c only do something when…
- [Low] The comment above the of_pci_make_dev_node() fixup block in
drivers/pci/quirks.c (lines 6553-6560) gives one reason for the…
--
PCI: Create OF node for NXP ENETC pseudo-MAC functions
This commit registers of_pci_make_dev_node() as a final fixup for the NXP
ENETC4 PCI device IDs 0xe101 and 0xe110. The new per-function OF node lets
the ENETC4 driver attach a fixed-link child to pseudo-MAC ports that have
no static DT node. The fixup only does anything when
CONFIG_PCI_DYNAMIC_OF_NODES is enabled.
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 7f1f47ea2ee41..71f272d8a2965 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -6563,6 +6563,8 @@ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_XILINX, 0x5021, of_pci_make_dev_node);
> DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_REDHAT, 0x0005, of_pci_make_dev_node);
> DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_EFAR, 0x9660, of_pci_make_dev_node);
> DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_TOSHIBA, 0x0220, of_pci_make_dev_node);
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_PHILIPS, 0xe101, of_pci_make_dev_node);
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_PHILIPS, 0xe110, of_pci_make_dev_node);
[Severity: Medium]
With the default arm64 config, will these fixups do anything on the
S32N79 platform this series targets?
If CONFIG_PCI_DYNAMIC_OF_NODES is not set, of_pci_make_dev_node() is an
empty stub:
drivers/pci/pci.h:
#else
static inline void of_pci_make_dev_node(struct pci_dev *pdev) { }
PCI_DYNAMIC_OF_NODES is a user-visible bool, and nothing in the tree
selects it. NXP_ENETC4 selects OF_DYNAMIC, so there is no build problem.
However, it does not select or imply PCI_DYNAMIC_OF_NODES.
arch/arm64/configs/defconfig sets CONFIG_ARCH_S32=y and
CONFIG_NXP_ENETC4=m, but it does not set PCI_DYNAMIC_OF_NODES.
The s32n79.dtsi change in this series adds netc_iep18 without child nodes
for the PCI functions. So dev->of_node stays NULL for the pseudo-MAC PF,
and enetc4_link_init() fails the probe:
drivers/net/ethernet/freescale/enetc/enetc4_pf.c:enetc4_link_init() {
...
if (!node) {
dev_err(dev, "Missing of_node for Pseudo-MAC port\n");
return -ENODEV;
}
...
}
This error message does not mention the missing config option.
So with the default arm64 config, "arm64: dts: s32n79-rdb: enable NETC
IEP18" does not get the PPM PF/VF instances probed, which is what it sets
out to do.
The commit messages say this dependency is intentional, because the
driver also handles ports described by static DT. That is a reason not to
add a hard "depends on". Would an "imply PCI_DYNAMIC_OF_NODES" on
NXP_ENETC4, or a defconfig update, work instead? The Kconfig help text
notes that turning the option on also creates OF nodes for all PCI
bridges.
[Severity: Low]
This isn't a bug, but the comment above this block of fixups no longer
covers every entry:
/*
* For a PCI device with multiple downstream devices, its driver may use
* a flattened device tree to describe the downstream devices.
* To overlay the flattened device tree, the PCI device and all its ancestor
* devices need to have device tree nodes on system base device tree. Thus,
* before driver probing, it might need to add a device tree node as the final
* fixup.
*/
An ENETC4 pseudo-MAC function has no downstream devices and loads no FDT
overlay. enetc4_add_ppm_fixed_link() only applies an of_changeset that
adds a fixed-link child to the function's own node.
The PCI_DYNAMIC_OF_NODES help text in drivers/pci/Kconfig also describes
only the overlay use case.
Could the comment, and perhaps the help text, be updated to cover this
use?
--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/cover.1794581338.git.claudiu.manoil%40nxp.com
prev parent reply other threads:[~2026-11-17 15:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1794581338.git.claudiu.manoil@nxp.com>
2026-11-13 15:02 ` [PATCH net-next v4 1/6] net: enetc: Add pseudo-MAC support for ENETCv4 Ports via a fixed-link node Claudiu Manoil
2026-11-17 15:55 ` netdev-bot+sashiko
2026-11-13 15:02 ` [PATCH net-next v4 2/6] net: enetc: Allocate int_vector array dynamically Claudiu Manoil
2026-11-13 15:02 ` [PATCH net-next v4 3/6] net: enetc: Enable probing of version 4.4 devices Claudiu Manoil
2026-11-17 15:55 ` netdev-bot+sashiko
2026-11-13 15:02 ` [PATCH net-next v4 4/6] arm64: dts: s32n79: add NETC IEP18 ECAM node for ENETC PPM ports Claudiu Manoil
2026-11-13 15:02 ` [PATCH net-next v4 5/6] arm64: dts: s32n79-rdb: enable NETC IEP18 Claudiu Manoil
2026-11-17 15:55 ` netdev-bot+sashiko
2026-11-13 15:02 ` [PATCH net-next v4 6/6] PCI: Create OF node for NXP ENETC pseudo-MAC functions Claudiu Manoil
2026-11-17 15:55 ` netdev-bot+sashiko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179493091275.3136.9482657927785539194@kernel.org \
--to=netdev-bot+sashiko@kernel.org \
--cc=bhelgaas@google.com \
--cc=claudiu.manoil@nxp.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=s32@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®