From: patchwork-bot+netdevbpf@kernel.org
To: Anthony Pighin <anthony.pighin@nokia.com>
Cc: netdev@vger.kernel.org, claudiu.manoil@nxp.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@kernel.org,
kuba@kernel.org, pabeni@redhat.com, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH net] net: gianfar: clear the pending Rx skb when freeing the Rx ring
Date: Wed, 18 Nov 2026 01:40:08 +0000 [thread overview]
Message-ID: <179496600877.1396957.13399889673438703423.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20261112143140.1395197-1-anthony.pighin@nokia.com>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 12 Nov 2026 09:31:40 -0500 you wrote:
> gfar_clean_rx_ring() keeps a frame that spans several Rx buffers in
> rx_queue->skb between NAPI polls. When the interface is stopped (close,
> MTU change, reset), free_skb_rx_queue() frees that skb but leaves the
> pointer set, and nothing clears it when the rings are set up again.
>
> After the restart, gfar_clean_rx_ring() picks up the stale pointer. The
> first buffer it sees has RXBD_FIRST set, so the overrun handling frees
> the skb a second time. By then the skb has usually been reallocated, so
> the second free releases another owner's skb and data while they are
> still in use.
>
> [...]
Here is the summary with links:
- [net] net: gianfar: clear the pending Rx skb when freeing the Rx ring
https://git.kernel.org/netdev/net/c/c35761f43c58
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2026-11-18 1:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 14:31 Anthony Pighin
2026-11-12 14:36 ` netdev-bot+sinfo
2026-11-12 14:47 ` Anthony Pighin
2026-11-16 9:46 ` Daniel Machon
2026-11-18 1:40 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179496600877.1396957.13399889673438703423.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.pighin@nokia.com \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®