mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: linux-block@vger.kernel.org, Md Haris Iqbal <haris.iqbal@linux.dev>
Cc: linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	 Keith Busch <kbusch@kernel.org>,
	Jonathan Corbet <corbet@lwn.net>,
	 linux-doc@vger.kernel.org
Subject: Re: [v4 0/3] block: delay support for error injection
Date: Wed, 18 Nov 2026 09:07:49 -0700	[thread overview]
Message-ID: <179501806989.17649.3138860274842922761.b4-ty@b4> (raw)
In-Reply-To: <20261111215838.103356-1-haris.iqbal@linux.dev>


On Wed, 11 Nov 2026 22:58:35 +0100, Md Haris Iqbal wrote:
> Error injection can only fail a bio today.  This adds a delay_us option so
> that a rule can hold a bio back first, to model a slow device.  The delay
> happens above the driver, so it tests the code waiting above the block
> layer, not the blk-mq timeout handler.
> 
> A delayed bio is marked with a new BIO_ERROR_INJECTED flag so the rules
> are not applied to it again, even after a split.  Christoph asked on v2
> to avoid the flag by allowing a delay only together with an error.  I kept
> delay-only rules, as a slow device that succeeds is the more useful case,
> so the flag question is still open.
> 
> [...]

Applied, thanks!

[1/3] block: Reject unknown status tags in error injection rules
      commit: d239710cf3e6bd5fec66766957c3752d9cfbd2c5
[2/3] block: allow error injection rules to delay bios
      commit: 6bd856cc99963b786cb530141745ef733de76cc3
[3/3] Documentation: block: document error injection delay feature
      commit: 5a29cfaf51105039d156dd8a61d2783e8b653667

Best regards,
-- 
Jens Axboe




  parent reply	other threads:[~2026-11-18 16:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11 21:58 Md Haris Iqbal
2026-11-11 21:58 ` [v4 1/3] block: Reject unknown status tags in error injection rules Md Haris Iqbal
2026-11-12 13:53   ` Christoph Hellwig
2026-11-11 21:58 ` [v4 2/3] block: allow error injection rules to delay bios Md Haris Iqbal
2026-11-12 13:54   ` Christoph Hellwig
2026-11-11 21:58 ` [v4 3/3] Documentation: block: document error injection delay feature Md Haris Iqbal
2026-11-12 13:54   ` Christoph Hellwig
2026-11-18 16:07 ` Jens Axboe [this message]
2026-11-20 16:44   ` [v4 0/3] block: delay support for error injection Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179501806989.17649.3138860274842922761.b4-ty@b4 \
    --to=axboe@kernel.dk \
    --cc=corbet@lwn.net \
    --cc=haris.iqbal@linux.dev \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®