From: "Rob Herring (Arm)" <robh@kernel.org>
To: Chi-Wen Weng <cwweng.linux@gmail.com>
Cc: nuno.sa@analog.com, dlechner@baylibre.com,
linux-arm-kernel@lists.infradead.org, jic23@kernel.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
conor+dt@kernel.org, cwweng@nuvoton.com, krzk+dt@kernel.org,
devicetree@vger.kernel.org, andy@kernel.org,
chernyakin.victor.j@outlook.com
Subject: Re: [PATCH v5 1/3] dt-bindings: iio: adc: Fix channel property validation
Date: Wed, 18 Nov 2026 10:31:53 -0600 [thread overview]
Message-ID: <179501951295.2811032.13608319647135153156.robh@kernel.org> (raw)
In-Reply-To: <20261117082832.1551574-2-cwweng.linux@gmail.com>
On Tue, 17 Nov 2026 16:28:30 +0800, Chi-Wen Weng wrote:
> From: Chi-Wen Weng <cwweng@nuvoton.com>
>
> The common ADC channel binding currently uses an anyOf constraint
> to require the reg property and select between single-channel and
> diff-channels.
>
> However, the reg-only branch allows validation to succeed even when
> both single-channel and diff-channels are present, bypassing the
> intended mutual exclusion.
>
> Replace the anyOf constraint with an explicit reg requirement and
> a not constraint that rejects channels specifying both properties.
>
> This preserves support for reg-only, single-ended and differential
> channel descriptions while rejecting conflicting configurations.
>
> Fixes: dd471a2b7759 ("dt-bindings: iio: adc: Add single-channel property")
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Chi-Wen Weng <cwweng@nuvoton.com>
> ---
> .../devicetree/bindings/iio/adc/adc.yaml | 17 +++++++----------
> 1 file changed, 7 insertions(+), 10 deletions(-)
>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
next prev parent reply other threads:[~2026-11-18 16:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 8:28 [PATCH v5 0/3] iio: adc: Add Nuvoton MA35D1 EADC support Chi-Wen Weng
2026-11-17 8:28 ` [PATCH v5 1/3] dt-bindings: iio: adc: Fix channel property validation Chi-Wen Weng
2026-11-18 16:31 ` Rob Herring (Arm) [this message]
2026-11-17 8:28 ` [PATCH v5 2/3] dt-bindings: iio: adc: Add Nuvoton MA35D1 EADC Chi-Wen Weng
2026-11-18 16:33 ` Rob Herring (Arm)
2026-11-17 8:28 ` [PATCH v5 3/3] iio: adc: Add Nuvoton MA35D1 EADC driver Chi-Wen Weng
2026-11-17 9:43 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179501951295.2811032.13608319647135153156.robh@kernel.org \
--to=robh@kernel.org \
--cc=andy@kernel.org \
--cc=chernyakin.victor.j@outlook.com \
--cc=conor+dt@kernel.org \
--cc=cwweng.linux@gmail.com \
--cc=cwweng@nuvoton.com \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®