From: "Rob Herring (Arm)" <robh@kernel.org>
To: Jernej Skrabec <jernej.skrabec@gmail.com>
Cc: airlied@gmail.com, jbrunet+clk@baylibre.com,
Samuel Holland <samuel@sholland.org>,
devicetree@vger.kernel.org, Chen-Yu Tsai <wens@kernel.org>,
linux-arm-kernel@lists.infradead.org,
dri-devel@lists.freedesktop.org, conor+dt@kernel.org,
bmasney+clk@redhat.com, simona@ffwll.ch,
linux-clk@vger.kernel.org, tzimmermann@suse.de, sboyd@kernel.org,
Andre Przywara <andre.przywara@arm.com>,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev,
krzk+dt@kernel.org
Subject: Re: [PATCH v3 7/8] dt-bindings: display: allwinner: Split H616 DE33 layer reg space
Date: Wed, 18 Nov 2026 15:13:36 -0600 [thread overview]
Message-ID: <179503641576.1032413.14291544816555567669.robh@kernel.org> (raw)
In-Reply-To: <20261115061102.229680-8-jernej.skrabec@gmail.com>
On Sun, 15 Nov 2026 07:11:01 +0100, Jernej Skrabec wrote:
> As it turns out, current H616 DE33 binding was written based on
> incomplete understanding of DE33 design. Namely, planes are shared
> resource and not tied to specific mixer, which was the case for previous
> generations of Display Engine (DE3 and earlier).
>
> This means that current DE33 binding doesn't properly reflect HW and
> using it would mean that second mixer (used for second display output)
> can't be supported.
>
> Remove layer register space, which will be represented with additional
> node, and replace it with phandle, which will point to that new, shared
> node. That way, all mixers can share same layers.
>
> This change is intentionally not backward compatible and the old binding
> will not be supported by the driver, for the following reasons:
>
> - It can't describe the hardware. Plane register space is shared
> between all mixers, but the old binding puts it in the mixer node, so
> only one mixer can ever claim it. The second mixer can't be supported
> with the old binding at all. It also has no way to reference plane to
> mixer mapping registers, which live in display clocks register space.
>
> - Supporting it would mean keeping a second, mixer-local plane
> management path in the driver, with hardcoded plane mapping, which
> doesn't match the hardware and which can't be tested, since nothing
> uses it.
>
> - It was never used. Upstream H616 DT has no Display Engine nodes and
> the rest of H616 display pipeline (TCON, HDMI, PHY) is not supported
> upstream yet, so the old binding never produced a working display.
> Vendor BSP kernels use a completely different DT structure and no
> other known DT consumer (U-Boot, *BSD, Zephyr, TF-A, ...) implements
> H616 display support. Only out of tree WIP patches used it and those
> are updated together with the kernel.
>
> The driver will print an error, asking to update the device tree, when
> the old binding is detected.
>
> Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
> ---
> .../display/allwinner,sun8i-a83t-de2-mixer.yaml | 16 ++++++++++------
> 1 file changed, 10 insertions(+), 6 deletions(-)
>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
next prev parent reply other threads:[~2026-11-18 21:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-15 6:10 [PATCH v3 0/8] drm/sun4i: update DE33 support Jernej Skrabec
2026-11-15 6:10 ` [PATCH v3 1/8] clk: sunxi-ng: de2: Fix Display Engine 3.3 definitions Jernej Skrabec
2026-11-15 6:10 ` [PATCH v3 2/8] clk: sunxi-ng: de2: Export register regmap for DE33 Jernej Skrabec
2026-11-15 6:10 ` [PATCH v3 3/8] drm/sun4i: Add support for DE33 CSC Jernej Skrabec
2026-11-15 6:10 ` [PATCH v3 4/8] drm/sun4i: vi_layer: Limit formats for DE33 Jernej Skrabec
2026-11-15 14:04 ` Chen-Yu Tsai
2026-11-15 6:10 ` [PATCH v3 5/8] dt-bindings: display: allwinner: Add DE33 planes Jernej Skrabec
2026-11-15 6:11 ` [PATCH v3 6/8] drm/sun4i: Add DE33 shared plane driver Jernej Skrabec
2026-11-15 14:01 ` Chen-Yu Tsai
2026-11-15 6:11 ` [PATCH v3 7/8] dt-bindings: display: allwinner: Split H616 DE33 layer reg space Jernej Skrabec
2026-11-15 14:06 ` Chen-Yu Tsai
2026-11-18 21:13 ` Rob Herring (Arm) [this message]
2026-11-15 6:11 ` [PATCH v3 8/8] drm/sun4i: Switch DE33 to split plane bindings Jernej Skrabec
2026-11-15 14:26 ` Chen-Yu Tsai
2026-11-15 14:37 ` Chen-Yu Tsai
2026-11-15 12:09 ` (subset) [PATCH v3 0/8] drm/sun4i: update DE33 support Chen-Yu Tsai
2026-11-15 14:42 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179503641576.1032413.14291544816555567669.robh@kernel.org \
--to=robh@kernel.org \
--cc=airlied@gmail.com \
--cc=andre.przywara@arm.com \
--cc=bmasney+clk@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jbrunet+clk@baylibre.com \
--cc=jernej.skrabec@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=samuel@sholland.org \
--cc=sboyd@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®