From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.216.54 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795059072; b=I7/WlIYg7F6UT1yGPCn4gvRKDfVJIrEq0i6HFGsFe/yBDeelasRK8hHPdCOCW8Kek51Y A3f4Ehlywg2SK6WU0CP6a/OBgPGfymahpLT9pFM1ru+FClisMOoc/8p4sdkFy5jX9DxeH 4igoCRZsbbrz+DaQNu5Mker6UTxydmWy33tFOJMlTfWm2T2kAG915W7wsyV8FT9Xto2Eo Gd8hwIr2GqoZSr5+EMsJgeuc9ZRxrd5ueVMPj/l7+Ch8R8ujUc2owMe7dWU7TmrlxjBQq OAsxURYMixPydXcHNd7ngUVDT3HguRu6yRc6MSDddrxQ8x8TmbtWDIv9U6XlHmyPfSw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795059072; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Date:From:To:Cc:Subject:Message-ID:Content-Type: Content-Transfer-Encoding:MIME-Version; bh=ZLlkYj3mBfiUcAIkRHyiL4FHQRqTFutxEfnrI2U+Iuk=; b=ePijiBdVtoPy0pTOkpch1ncilnLCjL0uNvGMFlQB/+x0e8EH/Qo1AiEKbN6lJqnCbx03 jPi5RGQ0jV7Y8qkV0pAjU/CFLwuMm6CIBSBP+hzE6Cwuc3kqNZZJvzPGyrYrR/upw71Qv JVRbCcYVOTQSy1YgM9h2b8olGPU2sTac0NPCZ7lE3i4/+p7lvCu3q0wmd9YGTvLOf113+ XoDQzdau4Sp3RrQih3/U8IME1BjGFfalE3PzyQVQOqfBv716axkRPWZFPifi0nsKDq4hz LuTmstXhb8UJ+Eb3LVaGrFMq0HKpjBsvOaNt48st9aVD2BLdmpVnODerMgE8pTN7PlQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=0FQh7JjM; arc=none smtp.remote-ip=209.85.216.54 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DB96606A33F for ; Thu, 19 Nov 2026 03:31:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 0DB96606A33F Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=0FQh7JjM Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-3acb11973c3so1525839a91.3 for ; Wed, 18 Nov 2026 19:31:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1795059071; x=1795663871; darn=vger.kernel.org; h=mime-version:content-transfer-encoding:content-type:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ZLlkYj3mBfiUcAIkRHyiL4FHQRqTFutxEfnrI2U+Iuk=; b=0FQh7JjMzMxqIXlV+YFPS3msR8b27sQJGLsSxfXFaC5aWWJ1nATPtAlHexGCutYqwz 6vRlMMji/8aykSLt2osM7jxzzw010kO/Zgeyuw4oJldVk4gjXrcI3VDhW+agphjpQyF6 3gr0L0t3/mDctLutM7g2AoG7nYrLNAKlUevPRkliCdFhlpsrRXL9xCSHd/2iYAXZoCFW 3AiHMEbSTMeT7Yz0e8fJHGSwA3BvlhmUXOjy2ADvz7dEh2U6qeWL3dTK4YNtCg9YAyS+ DZfFxEgDiHPStqtGEI5q95iWk8qE0Py0vvpSK5IbwnMfKT4KcLaKStaePqD6Zd2ppsYi w5bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795059071; x=1795663871; h=mime-version:content-transfer-encoding:content-type:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=ZLlkYj3mBfiUcAIkRHyiL4FHQRqTFutxEfnrI2U+Iuk=; b=gh+7/FdO97sgWrsT4boGd3jqmr1Bki3VpdmKOWZ0bY//kJ3NWQO4SFNwshjEMum5QW 4kocpEhhUgcSZJ+jksijlL81mRPBLMmlZyobC29CDzI7IvRN5nxfO2YbnYEcT5UiXMdL kxr35snB0tmlNaQ8gRpW93oUIA0n7QfuvA1Kjk+Dvb9OtTYCL95xPeZPeeiT1wo9sEc+ /FL5DmfcqodOIiooZePVtqMAjXENLJjprh95lLjIfvVdqt2edod0TfvBy67lXA2kEKBw FJnrR+JXycWDamI8ugQDrlDQN7iiiw6LOLQcW8d2A0Cqkgm7SGcwYYYgQnjOd1AKh2XL S1aA== X-Forwarded-Encrypted: i=1; AL+hErE+AhyOa2YkiEMvvTUNaxN6D8UZ5qc8p0nSXTliOHOFrcrqjPie60IURTXuaM5xZtaxmZw3wPFSMd//anU=@vger.kernel.org X-Gm-Message-State: APuU4Z82aQFmcrxb9+xLuhjSUug9hfURiGUVMOMEc1GbMvYnt/L9BzCi og7bE3wSL96NBk1K79cySZvUi+z8g9E03NP0iCE/c9q+fq3+byqnKPU2 X-Gm-Gg: AZFdTZcjobbxlP/+FQs2V3XvIgzoTowUMieskOfhQdzfUV+TCK6an2orc5e+nzgnrcc /b06RKzncPVuhe9xkKigFWPflCHBH/50mMDVThC2gpg6b5lUlESVyyh4LyEuJyVJBJqRcPuvdd7 HJWucBzPAJl0eplVzo0oIE/aF8toFLBuwIvODtsAj+1ouS97DwVNQkvpRUnGkSTCzfxV7ft1WkV IpDZXM6kctAhxmc7TARw0YNPZVpaM1hiLaH1wv9cgIsvaLbzP0Dfhj+ZXxjZ1hvABfC7N6IZUlX 5KnoeS9W0NuhPxirQg8gesPG4I563W4IyC/+OXJ/mz/E1o2FoXAZm6GWCb1yX22EX84PDflU/tF qvfgoAKxx2idvIa48Uui65ii71eC/ZQ2LxYKB3nMgELjfBgzX603WNrZgxKxtiHgeoHYkktJvlK 4MnOReeIPMUtwJYQl03hlOI8Dm2l8eLQQH2hDUAnQkHjldJNUrWtGrIkVibUCzIh169ZsR5IUcQ EderMw3eNrW14ebExhHWsFErtq1Efq/46QKr66e5pFDTZQFpluFI89eoKTRJWaDM6FGWwA= X-Received: by 2002:a17:90b:3c0b:b0:3ac:e6a:1b2b with SMTP id 98e67ed59e1d1-3b3d04d0f80mr4639475a91.0.1795059071362; Wed, 18 Nov 2026 19:31:11 -0800 (PST) Received: from [172.21.0.2] (vldb.skku.ac.kr. [115.145.173.180]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3b405d639fdsm254672a91.10.2026.11.18.19.31.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Nov 2026 19:31:10 -0800 (PST) Date: Wed, 18 Nov 2026 19:31:10 -0800 (PST) From: Kyuwon Cho To: netdev@vger.kernel.org Cc: Jay Vosburgh , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org Subject: [PATCH net v2] bonding: reject a non-Ethernet 802.3ad slave even when the type matches Message-ID: <179505868590.3571070.12381528230330714812@gmail.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Commit c84fcb79e5db ("bonding: limit BOND_MODE_8023AD to Ethernet devices") rejects a non-Ethernet first slave in 802.3ad mode, but only when enslaving it changes the bond's type. A bond keeps the type of its last slave after that slave is released, so a bond that once had an ARPHRD_TUNNEL6 slave can be set to 802.3ad and take another TUNNEL6 device, such as a second bond prepared the same way, without the check. bond_open() then adds the 8-byte lacpdu_mcast_addr to that slave with dev_mc_add(), which copies the slave's 16-byte addr_len: BUG: KASAN: global-out-of-bounds in __hw_addr_add_ex (net/core/dev_addr_lists.c:102 net/core/dev_addr_lists.c:157) Read of size 16 at addr ffffffff878a2940 by task test/114 Call Trace: __hw_addr_add_ex (net/core/dev_addr_lists.c:102 net/core/dev_addr_lists.c:157) dev_mc_add (net/core/dev_addr_lists.c:1036 net/core/dev_addr_lists.c:1054) bond_open (drivers/net/bonding/bond_main.c:4405) __dev_open (net/core/dev.c:1762) __dev_change_flags (net/core/dev.c:10022) netif_change_flags (net/core/dev.c:10087) do_setlink.isra.0 (net/core/rtnetlink.c:3294) rtnl_setlink (net/core/rtnetlink.c:3633) An unprivileged user can set this up in its own user and network namespace. Check that an 802.3ad slave is an Ethernet device before the type handling, for every slave. Fixes: c84fcb79e5db ("bonding: limit BOND_MODE_8023AD to Ethernet devices") Suggested-by: Jay Vosburgh Signed-off-by: Kyuwon Cho Reviewed-by: Eric Dumazet --- v2: - Move the check above the type handling, as Jay suggested, so it covers every slave. There is no functional change: the bond mode cannot change while it has slaves, and a later slave of another type was already rejected, only with a different message. Kept Eric's Reviewed-by. v1: https://lore.kernel.org/netdev/179500849159.1877154.14715369660816392826@gmail.com/ The patch was written with LLM assistance; we reviewed and tested it. With it, our reproducer no longer triggers the report, and enslaving Ethernet devices into an 802.3ad bond, or a non-Ethernet device into an active-backup bond, works as before. drivers/net/bonding/bond_main.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index 042d7c75548f..bcc12ef34d9a 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c @@ -1951,6 +1951,13 @@ int bond_enslave(struct net_device *bond_dev, struct net_device *slave_dev, return -EPERM; } + if (slave_dev->type != ARPHRD_ETHER && + BOND_MODE(bond) == BOND_MODE_8023AD) { + SLAVE_NL_ERR(bond_dev, slave_dev, extack, + "8023AD mode requires Ethernet devices"); + return -EINVAL; + } + /* set bonding device ether type by slave - bonding netdevices are * created with ether_setup, so when the slave type is not ARPHRD_ETHER * there is a need to override some of the type dependent attribs/funcs. @@ -1960,12 +1967,6 @@ int bond_enslave(struct net_device *bond_dev, struct net_device *slave_dev, */ if (!bond_has_slaves(bond)) { if (bond_dev->type != slave_dev->type) { - if (slave_dev->type != ARPHRD_ETHER && - BOND_MODE(bond) == BOND_MODE_8023AD) { - SLAVE_NL_ERR(bond_dev, slave_dev, extack, - "8023AD mode requires Ethernet devices"); - return -EINVAL; - } slave_dbg(bond_dev, slave_dev, "change device type from %d to %d\n", bond_dev->type, slave_dev->type);