From: Kyuwon Cho <kyuwoncho18@gmail.com>
To: Hangbin Liu <hangbin.liu@linux.dev>
Cc: netdev@vger.kernel.org, Jay Vosburgh <jv@jvosburgh.net>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2] bonding: reject a non-Ethernet 802.3ad slave even when the type matches
Date: Fri, 20 Nov 2026 07:29:09 -0800 (PST) [thread overview]
Message-ID: <179509928313.4181850.1728907555340063150@gmail.com> (raw)
In-Reply-To: <av7JE91kbL3gf8MS@fedora>
On Thu, Nov 19, 2026 at 06:01:55PM +0800, Hangbin Liu wrote:
> Hmm, should we also check and set the bond device type back to Ethernet
> when set mode to 8023AD?
With this patch the leftover type should not matter for 802.3ad: the
mode can only be changed while the bond has no slaves, every slave of
an 802.3ad bond now has to be an Ethernet device, and enslaving the
first one turns the bond back into an Ethernet device through
bond_ether_setup(). I checked that on this patch: a bond left as
ARPHRD_TUNNEL6 stays so after the mode change, becomes ARPHRD_ETHER
when the first Ethernet slave is added, and comes up fine.
Resetting the type at the mode change would also make an empty 802.3ad
bond look like Ethernet, which seems a reasonable cleanup, but it
changes the device type outside of enslave, so I would keep it out of
this fix. I can send it separately for net-next if you and Jay think it
is worth it.
Thanks,
Kyuwon Cho
prev parent reply other threads:[~2026-11-20 15:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 3:31 Kyuwon Cho
2026-11-19 10:01 ` Hangbin Liu
2026-11-20 15:29 ` Kyuwon Cho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179509928313.4181850.1728907555340063150@gmail.com \
--to=kyuwoncho18@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=hangbin.liu@linux.dev \
--cc=jv@jvosburgh.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®