mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: bod@kernel.org
To: Atanas Filipov <atanas.filipov@oss.qualcomm.com>
Cc: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	 Mauro Carvalho Chehab <mchehab@kernel.org>,
	 Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
	 Loic Poulain <loic.poulain@oss.qualcomm.com>,
	 Gjorgji Rosikopulos <gjorgji.rosikopulos@oss.qualcomm.com>,
	 linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 6/6] media: qcom: camss: sm8250: set the camera NoC AXI rate from the VFE
Date: Thu, 19 Nov 2026 15:38:41 +0000	[thread overview]
Message-ID: <179510272121.2846709.5296245274382118751.b4-reply@b4> (raw)
In-Reply-To: <20261028132403.3505037-7-atanas.filipov@oss.qualcomm.com>

On 2026-10-28 15:24 +0200, Atanas Filipov wrote:
> The SM8250 VFE resources list both the camera NoC AXI RCG,
> camnoc_axi_src, and its camnoc_axi branch. The camnoc_axi_src levels
> are never applied, since vfe_match_clock_names() does not match that
> name, and they list 480 MHz, which the RCG does not support. The
> camnoc_axi branch has no rates, so the camera NoC runs from XO and two
> concurrent streams stall.
> 
> Drop camnoc_axi_src, as the camnoc_axi branch keeps it enabled through
> its parent, and list the 300 and 400 MHz camera NoC AXI rates for the
> camnoc_axi branch, whose rate the VFE sets through the parent. The four
> VFEs share the camnoc_axi clock, so it runs at the highest rate
> requested by the running VFEs.
> 
> Signed-off-by: Atanas Filipov <atanas.filipov@oss.qualcomm.com>

Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
bod


  parent reply	other threads:[~2026-11-19 15:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-28 13:23 [PATCH v4 0/6] media: qcom: camss: share VFE clock sources by the highest rate Atanas Filipov
2026-10-28 13:23 ` [PATCH v4 1/6] media: qcom: camss: factor out the VFE minimum clock rate Atanas Filipov
2026-10-28 14:19   ` Loic Poulain
2026-10-28 13:23 ` [PATCH v4 2/6] media: qcom: camss: clamp VFE clock rates to the highest level Atanas Filipov
2026-10-28 14:31   ` Loic Poulain
2026-11-19 15:35   ` bod
2026-10-28 13:24 ` [PATCH v4 3/6] media: qcom: camss: sm8250: do not set VFE core clock rates from CSID Atanas Filipov
2026-10-28 13:24 ` [PATCH v4 4/6] media: qcom: camss: share VFE clock sources by the highest rate Atanas Filipov
2026-10-28 14:42   ` Loic Poulain
2026-10-28 13:24 ` [PATCH v4 5/6] media: qcom: camss: sm8250: set the VFE AREG clock rate from the VFE Atanas Filipov
2026-11-19 15:37   ` bod
2026-10-28 13:24 ` [PATCH v4 6/6] media: qcom: camss: sm8250: set the camera NoC AXI " Atanas Filipov
2026-10-28 14:37   ` Loic Poulain
2026-11-19 15:38   ` bod [this message]
2026-10-29 11:45 ` [PATCH v4 0/6] media: qcom: camss: share VFE clock sources by the highest rate Gjorgji Rosikopulos (Consultant)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179510272121.2846709.5296245274382118751.b4-reply@b4 \
    --to=bod@kernel.org \
    --cc=atanas.filipov@oss.qualcomm.com \
    --cc=bryan.odonoghue@linaro.org \
    --cc=gjorgji.rosikopulos@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=loic.poulain@oss.qualcomm.com \
    --cc=mchehab@kernel.org \
    --cc=vladimir.zapolskiy@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®