From: "Rob Herring (Arm)" <robh@kernel.org>
To: Billy Tsai <billy_tsai@aspeedtech.com>
Cc: linux-kernel@vger.kernel.org, linux-i3c@lists.infradead.org,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-aspeed@lists.ozlabs.org, tbevis@amazon.com,
Frank Li <Frank.Li@nxp.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
devicetree@vger.kernel.org,
Andrew Jeffery <andrew@codeconstruct.com.au>,
Ryan Chen <ryan_chen@aspeedtech.com>,
linux-arm-kernel@lists.infradead.org,
Miquel Raynal <miquel.raynal@bootlin.com>,
Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>
Subject: Re: [PATCH v2 2/9] dt-bindings: i3c: Document the AST2700 I3C controller
Date: Thu, 19 Nov 2026 17:21:46 -0600 [thread overview]
Message-ID: <179513050618.1478011.10339945188286451327.robh@kernel.org> (raw)
In-Reply-To: <20261111-b4-i3c-hci-ast2700-v2-2-4d8fff5c5196@aspeedtech.com>
On Wed, 11 Nov 2026 11:16:30 +0800, Billy Tsai wrote:
> The AST2700 I3C controller implements the MIPI I3C HCI programming
> model, extended with an ASPEED in-house control block and a PHY
> programming window advertised through an HCI vendor extended
> capability.
>
> The controller takes a core clock for PHY timing and two resets,
> named in reset-names as the controller's own reset and its DMA engine
> reset.
>
> Boards without external I3C pull-up resistors can use the PHY's
> built-in pull-ups instead, selected with bias-pull-up; the achievable
> strength set depends on which pin group backs the bus, since that
> fixes the pin voltage domain. Reuse bias-pull-up (pincfg-node.yaml)
> for the strength in Ohms; it is declared on this node rather than a
> pin-config node since the pull-up switch is part of the I3C PHY, not
> the broader SoC pin control IPs.
>
> Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
>
> ---
> We considered expressing bias-pull-up's dependency on a pinctrl state
> in the schema, but couldn't find a clean way to say "depends on
> whichever pinctrl-N is active" without hard-coding pinctrl-0
> specifically, which would be wrong in general (a node's active pin
> state doesn't have to sit at index 0). We've added pinctrl-0 to the
> example to illustrate the typical usage instead, without a formal
> schema-level dependency.
> ---
> .../bindings/i3c/aspeed,ast2700-i3c-hci.yaml | 89 ++++++++++++++++++++++
> 1 file changed, 89 insertions(+)
>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
next prev parent reply other threads:[~2026-11-19 23:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 3:16 [PATCH v2 0/9] i3c: mipi-i3c-hci: Add Aspeed AST2700 support Billy Tsai
2026-11-11 3:16 ` [PATCH v2 1/9] dt-bindings: i3c: Document generic bus timing properties Billy Tsai
2026-11-11 16:50 ` Frank Li
2026-11-18 3:26 ` 回覆: " Billy Tsai
2026-11-11 3:16 ` [PATCH v2 2/9] dt-bindings: i3c: Document the AST2700 I3C controller Billy Tsai
2026-11-19 23:21 ` Rob Herring (Arm) [this message]
2026-11-11 3:16 ` [PATCH v2 3/9] i3c: mipi-i3c-hci: Support address-indexed DAT slots Billy Tsai
2026-11-11 3:16 ` [PATCH v2 4/9] i3c: mipi-i3c-hci: Add a quirk for 64-bit DMA addressing Billy Tsai
2026-11-11 3:16 ` [PATCH v2 5/9] i3c: mipi-i3c-hci: Add a quirk to clear the TX start threshold Billy Tsai
2026-11-11 3:16 ` [PATCH v2 6/9] i3c: mipi-i3c-hci: Add support for the AST2700 I3C controller Billy Tsai
2026-11-11 17:11 ` Frank Li
2026-11-18 3:27 ` 回覆: " Billy Tsai
2026-11-11 3:16 ` [PATCH v2 7/9] i3c: mipi-i3c-hci: Program AST2700 IBI termination threshold Billy Tsai
2026-11-11 17:21 ` Frank Li
2026-11-18 3:32 ` 回覆: " Billy Tsai
2026-11-11 3:16 ` [PATCH v2 8/9] i3c: mipi-i3c-hci: Improve AST2700 PIO TX queue utilization Billy Tsai
2026-11-11 3:16 ` [PATCH v2 9/9] i3c: mipi-i3c-hci: Support the AST2700 internal pull-ups Billy Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179513050618.1478011.10339945188286451327.robh@kernel.org \
--to=robh@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@codeconstruct.com.au \
--cc=billy_tsai@aspeedtech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=p.zabel@pengutronix.de \
--cc=ryan_chen@aspeedtech.com \
--cc=tbevis@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®