From: Vinod Koul <vkoul@kernel.org>
To: "Amélie Delaunay" <amelie.delaunay@foss.st.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Xiangwu Lai" <laixiangwu@cmss.chinamobile.com>
Cc: Frank Li <Frank.Li@kernel.org>,
dmaengine@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: stm32-mdma: Fix runtime PM reference leak in pm_suspend
Date: Fri, 20 Nov 2026 15:34:37 +0530 [thread overview]
Message-ID: <179516907748.54365.16971204267682074561.b4-ty@kernel.org> (raw)
In-Reply-To: <20261102104432.873-1-laixiangwu@cmss.chinamobile.com>
On Mon, 02 Nov 2026 18:44:31 +0800, Xiangwu Lai wrote:
> stm32_mdma_pm_suspend() increments the runtime PM usage counter with
> pm_runtime_resume_and_get(), but when a channel is still enabled it
> returns -EBUSY directly without dropping the reference. The matching
> pm_runtime_put_sync() only runs on the success path.
>
> Each failed suspend attempt therefore leaks one runtime PM reference,
> so the device can never runtime suspend afterwards. Drop the
> reference before returning -EBUSY.
>
> [...]
Applied, thanks!
[1/1] dmaengine: stm32-mdma: Fix runtime PM reference leak in pm_suspend
commit: 34c8c2ea213aab7b452df93e5b7547f4459a49e9
Best regards,
--
~Vinod
prev parent reply other threads:[~2026-11-20 10:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 10:44 Xiangwu Lai
2026-11-02 12:23 ` Amelie Delaunay
2026-11-02 21:13 ` Frank Li
2026-11-20 7:34 ` [PATCH] dmaengine: stm32-mdma: Fix runtime PM reference leak in pm_suspend() Xiangwu Lai
2026-11-20 10:04 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179516907748.54365.16971204267682074561.b4-ty@kernel.org \
--to=vkoul@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=amelie.delaunay@foss.st.com \
--cc=dmaengine@vger.kernel.org \
--cc=laixiangwu@cmss.chinamobile.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®