mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: bod@kernel.org
To: Allan Siriani <allan@fatecpompeia.edu.br>
Cc: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	 Mauro Carvalho Chehab <mchehab@kernel.org>,
	 Loic Poulain <loic.poulain@oss.qualcomm.com>,
	 Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
	 Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	 Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	 Todor Tomov <todor.too@gmail.com>,
	Hans Verkuil <hverkuil@kernel.org>,
	 linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] media: qcom: camss: vfe-4-1: program the RDI write master buffer size
Date: Fri, 20 Nov 2026 11:38:16 +0000	[thread overview]
Message-ID: <179517469651.2846709.9395424676021708329.b4-reply@b4> (raw)
In-Reply-To: <20261109112611.94010-3-allan@fatecpompeia.edu.br>

On 2026-11-09 08:26 -0300, Allan Siriani wrote:
> The RDI outputs use the write masters in frame based mode. In that mode
> vfe_wm_frame_based() only sets the FRM_BASED bit of WR_CFG and leaves
> WR_BUFFER_CFG and WR_IMAGE_SIZE untouched: they keep their reset value or
> whatever a previous line based (PIX) stream left there, so nothing tells
> the write master how big the buffer is. If the sensor sends more data
> than the configured format, the write master keeps writing past the end
> of the V4L2 buffer. When the CAMSS runs without an IOMMU, as on
> MSM8226 today (the SoC has one, but it is not described in the upstream
> DT; its VFE 4.0 shares this register layout), that corrupts unrelated
> memory.
> 
> Program WR_BUFFER_CFG in frame based mode as the downstream VFE 4.0/4.1
> driver does (msm_vfe40_axi_cfg_wm_reg(): words per line, lines minus one
> and burst length, IMAGE_SIZE unused), from the bytesperline and height
> of the active format, and clear it again when the write master is
> released.
> 
> Pass the active format to the wm_frame_based() op for that. The VFE 4.7
> and 4.8 implementations, which use a different register layout, are left
> unchanged.
> 
> Signed-off-by: Allan Siriani <allan@fatecpompeia.edu.br>

Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
bod


  parent reply	other threads:[~2026-11-20 11:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-09 11:26 [PATCH v2 0/4] media: qcom: camss: contiguous buffers, RDI and CSID1 streaming fixes Allan Siriani
2026-11-09 11:26 ` [PATCH v2 1/4] media: qcom: camss: Use contiguous DMA buffers Allan Siriani
2026-11-09 11:26 ` [PATCH v2 2/4] media: qcom: camss: vfe-4-1: program the RDI write master buffer size Allan Siriani
2026-11-09 12:57   ` Bryan O'Donoghue
2026-11-09 17:17     ` Allan Siriani
2026-11-20 11:38   ` bod [this message]
2026-11-09 11:26 ` [PATCH v2 3/4] media: qcom: camss: always stop the pipeline in stop_streaming Allan Siriani
2026-11-09 12:56   ` Loic Poulain
2026-11-09 13:02   ` Bryan O'Donoghue
2026-11-09 17:17     ` Allan Siriani
2026-11-09 11:26 ` [PATCH v2 4/4] media: qcom: camss: do not fail CSID power up without a matching VFE Allan Siriani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179517469651.2846709.9395424676021708329.b4-reply@b4 \
    --to=bod@kernel.org \
    --cc=allan@fatecpompeia.edu.br \
    --cc=bryan.odonoghue@linaro.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=hverkuil@kernel.org \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=loic.poulain@oss.qualcomm.com \
    --cc=mchehab@kernel.org \
    --cc=todor.too@gmail.com \
    --cc=vladimir.zapolskiy@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®